Re: [PATCH, v2, libgomp, OpenMP 5.0] Implement omp_get_device_num

2021-08-05 Thread Chung-Lin Tang
On 2021/8/3 8:22 PM, Thomas Schwinge wrote: Hi Chung-Lin! On 2021-08-02T21:10:57+0800, Chung-Lin Tang wrote: --- a/libgomp/fortran.c +++ b/libgomp/fortran.c +int32_t +omp_get_device_num_ (void) +{ + return omp_get_device_num (); +} Missing 'ialias_redirect (omp_get_device_num)'? Grü

Re: [PATCH, v2, libgomp, OpenMP 5.0] Implement omp_get_device_num

2021-08-03 Thread Thomas Schwinge
Hi Chung-Lin! On 2021-08-02T21:10:57+0800, Chung-Lin Tang wrote: > --- a/libgomp/fortran.c > +++ b/libgomp/fortran.c > +int32_t > +omp_get_device_num_ (void) > +{ > + return omp_get_device_num (); > +} Missing 'ialias_redirect (omp_get_device_num)'? Grüße Thomas - Siemens El

Re: [PATCH, v2, libgomp, OpenMP 5.0] Implement omp_get_device_num

2021-08-03 Thread Thomas Schwinge
Hi Chung-Lin! Just a few quick comments: On 2021-08-02T21:10:57+0800, Chung-Lin Tang wrote: > On 2021/7/23 6:39 PM, Jakub Jelinek wrote: >> On Fri, Jul 23, 2021 at 06:21:41PM +0800, Chung-Lin Tang wrote: >>> --- a/libgomp/icv-device.c >>> +++ b/libgomp/icv-device.c >>> @@ -61,8 +61,17 @@ omp_is_

Re: [PATCH, v2, libgomp, OpenMP 5.0] Implement omp_get_device_num

2021-08-03 Thread Jakub Jelinek via Gcc-patches
On Mon, Aug 02, 2021 at 09:10:57PM +0800, Chung-Lin Tang wrote: > > I think this won't work properly with the intel micoffload, where the host > > libgomp is used in the offloaded code. > > For omp_is_initial_device, the plugin solves it by: > > liboffloadmic/plugin/offload_target_main.cpp > > over

[PATCH, v2, libgomp, OpenMP 5.0] Implement omp_get_device_num

2021-08-02 Thread Chung-Lin Tang
On 2021/7/23 6:39 PM, Jakub Jelinek wrote: On Fri, Jul 23, 2021 at 06:21:41PM +0800, Chung-Lin Tang wrote: --- a/libgomp/icv-device.c +++ b/libgomp/icv-device.c @@ -61,8 +61,17 @@ omp_is_initial_device (void) return 1; } +int +omp_get_device_num (void) +{ + /* By specification, this i