Re: [PATCH][2/2] early LTO debug, main part

On Thu, Sep 21, 2017 at 04:29:34PM +0200, Pierre-Marie de Rodat wrote: > On 09/20/2017 08:08 PM, Jeff Law wrote: > > > As for general DWARF5 testing, I think best coverage is GDB (say guality > > > testing with -gdwarf-5), I think GDB 8.0 should have the needed support. > > > I'll try to install

Re: [PATCH][2/2] early LTO debug, main part

On 09/20/2017 08:08 PM, Jeff Law wrote: As for general DWARF5 testing, I think best coverage is GDB (say guality testing with -gdwarf-5), I think GDB 8.0 should have the needed support. I'll try to install it (am only at 7.12.1 right now) and try to do some testing. > What about Pierre-Marie's

Re: [PATCH][2/2] early LTO debug, main part

On 09/20/2017 02:31 AM, Jakub Jelinek wrote: > On Wed, Sep 20, 2017 at 10:20:03AM +0200, Richard Biener wrote: >> Anyway, I did a quick LTO bootstrap with your patch and it seems >> to work fine. >> >> Can you add a testcase verifying -gdwarf-5 works ok (properly >> emitting a debug_line_str

Re: [PATCH][2/2] early LTO debug, main part

On Wed, Sep 20, 2017 at 10:20:03AM +0200, Richard Biener wrote: > Anyway, I did a quick LTO bootstrap with your patch and it seems > to work fine. > > Can you add a testcase verifying -gdwarf-5 works ok (properly > emitting a debug_line_str section?). I'm afraid I can't. We don't have a command

Re: [PATCH][2/2] early LTO debug, main part

On Tue, 19 Sep 2017, Jakub Jelinek wrote: > On Tue, Sep 19, 2017 at 05:24:14PM +0200, Jakub Jelinek wrote: > > These changes broke DWARF-5 support. E.g. in gcc-7 and before this change > > there was: Sorry for the breakage I had to manually merge conflicts in this part quite a few times since

Re: [PATCH][2/2] early LTO debug, main part

On Tue, Sep 19, 2017 at 05:24:14PM +0200, Jakub Jelinek wrote: > These changes broke DWARF-5 support. E.g. in gcc-7 and before this change > there was: Here is a fix, make check-g++ RUNTESTFLAGS=dwarf2.exp now passes again even with !DWARF2_ASM_LINE_DEBUG_INFO compiler. Haven't tried LTO

Re: [PATCH][2/2] early LTO debug, main part

On Fri, Aug 04, 2017 at 02:21:29PM +0200, Richard Biener wrote: > ! /* Initialize the various sections and labels for dwarf output. */ > > static void > ! init_sections_and_labels (void) ... These changes broke DWARF-5 support. E.g. in gcc-7 and before this change there was: > ! if

Re: [PATCH][2/2] early LTO debug, main part

On Tue, 22 Aug 2017, Szabolcs Nagy wrote: > On 22/08/17 11:17, Richard Biener wrote: > > On Tue, 22 Aug 2017, Szabolcs Nagy wrote: > >> on aarch64_be-none-elf i see > >> > >> PASS->FAIL: gcc.dg/debug/pr41893-1.c -gdwarf-2 (test for excess errors) > >> PASS->FAIL: gcc.dg/debug/pr41893-1.c

Re: [PATCH][2/2] early LTO debug, main part

On 22/08/17 11:17, Richard Biener wrote: > On Tue, 22 Aug 2017, Szabolcs Nagy wrote: >> on aarch64_be-none-elf i see >> >> PASS->FAIL: gcc.dg/debug/pr41893-1.c -gdwarf-2 (test for excess errors) >> PASS->FAIL: gcc.dg/debug/pr41893-1.c -gdwarf-2 -O (test for excess errors) >> PASS->FAIL:

Re: [PATCH][2/2] early LTO debug, main part

On Tue, 22 Aug 2017, Szabolcs Nagy wrote: > On 04/08/17 13:21, Richard Biener wrote: > > On Thu, 3 Aug 2017, Jason Merrill wrote: > >> OK if testing passes. > > > > Thanks. Meanwhile testing passed. > > > > Bootstrapped and tested on x86_64-unknown-linux-gnu, LTO bootstrapped > > on

Re: [PATCH][2/2] early LTO debug, main part

On 04/08/17 13:21, Richard Biener wrote: > On Thu, 3 Aug 2017, Jason Merrill wrote: >> OK if testing passes. > > Thanks. Meanwhile testing passed. > > Bootstrapped and tested on x86_64-unknown-linux-gnu, LTO bootstrapped > on x86_64-unknown-linux-gnu (both all languages). I've successfully >

Re: [PATCH][2/2] early LTO debug, main part

On Thu, 3 Aug 2017, Jason Merrill wrote: > On Thu, Aug 3, 2017 at 6:51 AM, Richard Biener wrote: > > On Wed, 2 Aug 2017, Jason Merrill wrote: > > > >> On Wed, Aug 2, 2017 at 6:35 AM, Richard Biener wrote: > >> > On Wed, 2 Aug 2017, Jason Merrill wrote: > >>

Re: [PATCH][2/2] early LTO debug, main part

On Thu, Aug 3, 2017 at 6:51 AM, Richard Biener wrote: > On Wed, 2 Aug 2017, Jason Merrill wrote: > >> On Wed, Aug 2, 2017 at 6:35 AM, Richard Biener wrote: >> > On Wed, 2 Aug 2017, Jason Merrill wrote: >> > >> >> On 05/19/2017 06:42 AM, Richard Biener wrote:

Re: [PATCH][2/2] early LTO debug, main part

On Wed, 2 Aug 2017, Jason Merrill wrote: > On Wed, Aug 2, 2017 at 6:35 AM, Richard Biener wrote: > > On Wed, 2 Aug 2017, Jason Merrill wrote: > > > >> On 05/19/2017 06:42 AM, Richard Biener wrote: > >> > + /* ??? In some cases the C++ FE (at least) fails to > >> > +

Re: [PATCH][2/2] early LTO debug, main part

On Wed, Aug 2, 2017 at 6:35 AM, Richard Biener wrote: > On Wed, 2 Aug 2017, Jason Merrill wrote: > >> On 05/19/2017 06:42 AM, Richard Biener wrote: >> > + /* ??? In some cases the C++ FE (at least) fails to >> > +set DECL_CONTEXT properly. Simply globalize stuff

Re: [PATCH][2/2] early LTO debug, main part

On Wed, 2 Aug 2017, Jason Merrill wrote: > On 05/19/2017 06:42 AM, Richard Biener wrote: > > + /* ??? In some cases the C++ FE (at least) fails to > > +set DECL_CONTEXT properly. Simply globalize stuff > > +in this case. For example > > +__dso_handle created via

Re: [PATCH][2/2] early LTO debug, main part

On 05/19/2017 06:42 AM, Richard Biener wrote: + /* ??? In some cases the C++ FE (at least) fails to +set DECL_CONTEXT properly. Simply globalize stuff +in this case. For example +__dso_handle created via iostream line 74 col 25. */ + parent = comp_unit_die ();

Re: [PATCH][2/2] early LTO debug, main part

On Tue, 20 Jun 2017, Richard Biener wrote: > On Wed, 7 Jun 2017, Richard Biener wrote: > > > On Fri, 19 May 2017, Richard Biener wrote: > > > > > > > > This is a repost of the main part of the early LTO debug support. > > > The only changes relative to the last post is in the dwarf2out.c > > >

Re: [PATCH][2/2] early LTO debug, main part

On Wed, 7 Jun 2017, Richard Biener wrote: > On Fri, 19 May 2017, Richard Biener wrote: > > > > > This is a repost of the main part of the early LTO debug support. > > The only changes relative to the last post is in the dwarf2out.c > > pieces due to Jasons review and Jakubs introduction of > >

Re: [PATCH][2/2] early LTO debug, main part

On Fri, 19 May 2017, Richard Biener wrote: > > This is a repost of the main part of the early LTO debug support. > The only changes relative to the last post is in the dwarf2out.c > pieces due to Jasons review and Jakubs introduction of > DW_OP_GNU_variable_value. > > I've also adjusted

[PATCH][2/2] early LTO debug, main part

This is a repost of the main part of the early LTO debug support. The only changes relative to the last post is in the dwarf2out.c pieces due to Jasons review and Jakubs introduction of DW_OP_GNU_variable_value. I've also adjusted testcases for fallout (the asan backtraces do give files / line

Re: [PING][PATCH][2/2] Early LTO debug -- main part

Late response now that I'm finished refreshing the patches. On Mon, Nov 28, 2016 at 6:20 PM, Jason Merrill wrote: > On Thu, Nov 24, 2016 at 8:50 AM, Richard Biener wrote: >>> > + /* ??? We can't annotate types late, but for LTO we may not >>> > +

Re: [PING][PATCH][2/2] Early LTO debug -- main part

On Thu, Nov 24, 2016 at 8:50 AM, Richard Biener wrote: >> > + /* ??? We can't annotate types late, but for LTO we may not >> > +generate a location early either (gfortran.dg/save_5.f90). >> > +The proper way is to handle it like VLAs though it is told >> > +

Re: [PING][PATCH][2/2] Early LTO debug -- main part

On Thu, 24 Nov 2016, Richard Biener wrote: > On Tue, 22 Nov 2016, Jason Merrill wrote: > > > On 11/11/2016 03:06 AM, Richard Biener wrote: > > > +/* ??? In some cases the C++ FE (at least) fails to > > > + set DECL_CONTEXT properly. Simply globalize stuff > > > + in this case.

Re: [PING][PATCH][2/2] Early LTO debug -- main part

On Tue, 22 Nov 2016, Jason Merrill wrote: > On 11/11/2016 03:06 AM, Richard Biener wrote: > > +/* ??? In some cases the C++ FE (at least) fails to > > + set DECL_CONTEXT properly. Simply globalize stuff > > + in this case. For example > > + __dso_handle created via

Re: [PING][PATCH][2/2] Early LTO debug -- main part

On 11/11/2016 03:06 AM, Richard Biener wrote: +/* ??? In some cases the C++ FE (at least) fails to + set DECL_CONTEXT properly. Simply globalize stuff + in this case. For example + __dso_handle created via iostream line 74 col 25. */ The comment for DECL_CONTEXT says

[PING][PATCH][2/2] Early LTO debug -- main part

On Fri, 21 Oct 2016, Richard Biener wrote: > > This is the main part of the early LTO debug support. The main parts > of the changes are to dwarf2out.c where most of the changes are related > to the fact that we eventually have to output debug info twice, once > for the early LTO part and once

[PATCH][2/2] Early LTO debug -- main part

This is the main part of the early LTO debug support. The main parts of the changes are to dwarf2out.c where most of the changes are related to the fact that we eventually have to output debug info twice, once for the early LTO part and once for the fat part of the object file. Bootstrapped and