Re: [PATCH][AArch64] Fixup core tunings

2019-12-18 Thread Kyrill Tkachov
Hi Wilco, On 12/17/19 4:03 PM, Wilco Dijkstra wrote: Hi Richard, > This changelog entry is inadequate.  It's also not in the correct style. > > It should say what has changed, not just that it has changed. Sure, but there is often no useful space for that. We should auto generate changelogs if

Re: [PATCH][AArch64] Fixup core tunings

2019-12-17 Thread Wilco Dijkstra
Hi Richard, > This changelog entry is inadequate.  It's also not in the correct style. > > It should say what has changed, not just that it has changed. Sure, but there is often no useful space for that. We should auto generate changelogs if they are deemed useful. I find the commit message a lot

Re: [PATCH][AArch64] Fixup core tunings

2019-12-13 Thread Richard Earnshaw (lists)
On 13/12/2019 12:23, Wilco Dijkstra wrote: Several tuning settings in cores.def are not consistent. Set the tuning for Cortex-A76AE and Cortex-A77 to neoversen1 so it is the same as for Cortex-A76 and Neoverse N1. Set the tuning for Neoverse E1 to cortexa73 so it's the same as for Cortex-A65. Set

[PATCH][AArch64] Fixup core tunings

2019-12-13 Thread Wilco Dijkstra
Several tuning settings in cores.def are not consistent. Set the tuning for Cortex-A76AE and Cortex-A77 to neoversen1 so it is the same as for Cortex-A76 and Neoverse N1. Set the tuning for Neoverse E1 to cortexa73 so it's the same as for Cortex-A65. Set the scheduler for Cortex-A65 and Cortex-A65A