Re: [PATCH][ARM] Fix PR target/69245 Rewrite arm_set_current_function

2016-01-26 Thread Kyrill Tkachov
On 26/01/16 16:56, Christian Bruel wrote: On 01/26/2016 04:58 PM, Kyrill Tkachov wrote: Hi Christian, On 26/01/16 15:29, Christian Bruel wrote: On 01/25/2016 05:37 PM, Kyrill Tkachov wrote: So this is ok for trunk with the testcase changed as discussed above and using -O2 optimisation l

Re: [PATCH][ARM] Fix PR target/69245 Rewrite arm_set_current_function

2016-01-26 Thread Kyrill Tkachov
Hi Christian, On 26/01/16 15:29, Christian Bruel wrote: On 01/25/2016 05:37 PM, Kyrill Tkachov wrote: So this is ok for trunk with the testcase changed as discussed above and using -O2 optimisation level and with a couple comment fixes below. Hi Kyrill, I realized afterwards that my imple

Re: [PATCH][ARM] Fix PR target/69245 Rewrite arm_set_current_function

2016-01-25 Thread Kyrill Tkachov
On 22/01/16 14:51, Christian Bruel wrote: Hi Kyrill, On 01/22/2016 03:17 PM, Kyrill Tkachov wrote: Hi Christian, On 22/01/16 14:07, Christian Bruel wrote: Hi Kyrill, On 01/21/2016 01:22 PM, Kyrill Tkachov wrote: Hi Christian, On 21/01/16 10:36, Christian Bruel wrote: The current arm_set_c

Re: [PATCH][ARM] Fix PR target/69245 Rewrite arm_set_current_function

2016-01-22 Thread Kyrill Tkachov
Hi Christian, On 22/01/16 14:07, Christian Bruel wrote: Hi Kyrill, On 01/21/2016 01:22 PM, Kyrill Tkachov wrote: Hi Christian, On 21/01/16 10:36, Christian Bruel wrote: The current arm_set_current_function was both awkward and buggy. For instance using partially set TARGET_OPTION set from p

Re: [PATCH][ARM] Fix PR target/69245 Rewrite arm_set_current_function

2016-01-21 Thread Kyrill Tkachov
Hi Christian, On 21/01/16 10:36, Christian Bruel wrote: The current arm_set_current_function was both awkward and buggy. For instance using partially set TARGET_OPTION set from pragma_parse, while restore_target_globalsnor arm_option_params_internal was not reset. Another issue is that in some p