Re: [PATCH][ARM] PR target/70008

2016-03-06 Thread Ramana Radhakrishnan
On Mon, Mar 7, 2016 at 3:51 AM, Michael Collison wrote: > New patch that adds the predicate "reg_or_arm_rhs_operand" as suggested by > Richard. Tested on all arm and thumb targets as before. > > Okay for trunk? Missing comment on the predicate. Ok, please queue this

Re: [PATCH][ARM] PR target/70008

2016-03-06 Thread Michael Collison
New patch that adds the predicate "reg_or_arm_rhs_operand" as suggested by Richard. Tested on all arm and thumb targets as before. Okay for trunk? 2016-03-07 Michael Collison PR target/70008 * config/arm/predicates.md (reg_or_arm_rhs_operand): New

Re: [PATCH][ARM] PR target/70008

2016-03-03 Thread Richard Earnshaw (lists)
On 03/03/16 07:23, Michael Collison wrote: > I have attached a new patch which hopefully address Richard's concerns. > I modified the predicate on operand 1 to to "arm_rhs_operand" to be > consistent with the constraints. I retained the split into two patterns; > one for arm and another for

Re: [PATCH][ARM] PR target/70008

2016-03-02 Thread Michael Collison
I have attached a new patch which hopefully address Richard's concerns. I modified the predicate on operand 1 to to "arm_rhs_operand" to be consistent with the constraints. I retained the split into two patterns; one for arm and another for thumb2. I thought this was cleaner. Okay for trunk?

Re: [PATCH][ARM] PR target/70008

2016-03-01 Thread Michael Collison
Hi Richard, I think we could incorporate your feedback by changing the predicate on operand 1 to "arm_rhs_operand" which allows "s_register_operand" or "arm_immediate_operand". Everything else in my patch would stay the same including splitting the thumb2 pattern out into it's own insn. I'm

Re: [PATCH][ARM] PR target/70008

2016-02-29 Thread Richard Earnshaw (lists)
On 29/02/16 11:21, Michael Collison wrote: > > > On 2/29/2016 4:06 AM, Kyrill Tkachov wrote: >> Hi Michael, >> >> On 29/02/16 04:47, Michael Collison wrote: >>> This patches address PR 70008, where a reverse subtract with carry >>> instruction can be generated in thumb2 mode. It was tested with

Re: [PATCH][ARM] PR target/70008

2016-02-29 Thread Michael Collison
On 2/29/2016 4:06 AM, Kyrill Tkachov wrote: Hi Michael, On 29/02/16 04:47, Michael Collison wrote: This patches address PR 70008, where a reverse subtract with carry instruction can be generated in thumb2 mode. It was tested with no regressions in arm and thumb modes on the following

Re: [PATCH][ARM] PR target/70008

2016-02-29 Thread Kyrill Tkachov
Hi Michael, On 29/02/16 04:47, Michael Collison wrote: This patches address PR 70008, where a reverse subtract with carry instruction can be generated in thumb2 mode. It was tested with no regressions in arm and thumb modes on the following targets: arm-none-linux-gnueabi

[PATCH][ARM] PR target/70008

2016-02-28 Thread Michael Collison
This patches address PR 70008, where a reverse subtract with carry instruction can be generated in thumb2 mode. It was tested with no regressions in arm and thumb modes on the following targets: arm-none-linux-gnueabi arm-none-linux-gnuabihf armeb-none-linux-gnuabihf arm-none-eabi Okay for