Re: [PATCH][ARM] Remove support for MULS

2020-02-04 Thread Wilco Dijkstra
Any further comments? Note GCC doesn't support S/UMULLS either since it is equally useless. It's no surprise that Thumb-2 removed support for flag-setting 64-bit multiplies, while AArch64 didn't add flag-setting multiplies. So there is no argument that these instructions are in any way useful to

Re: [PATCH][ARM] Remove support for MULS

2019-10-10 Thread Wilco Dijkstra
Any further comments? Note GCC doesn't support S/UMULLS either since it is equally useless. It's no surprise that Thumb-2 removed support for flag-setting 64-bit multiplies, while AArch64 didn't add flag-setting multiplies. So there is no argument that these instructions are in any way useful to

Re: [PATCH][ARM] Remove support for MULS

2019-09-19 Thread Wilco Dijkstra
Hi Richard, Kyrill, >> I disagree. If they still trigger and generate better code than without >> we should keep them. > >> What kind of code is *common* varies greatly from user to user. Not really - doing a multiply and checking whether the result is zero is exceedingly rare. I found only 3 c

Re: [PATCH][ARM] Remove support for MULS

2019-09-19 Thread Richard Earnshaw (lists)
On 18/09/2019 17:31, Kyrill Tkachov wrote: Hi Wilco, On 9/9/19 6:07 PM, Wilco Dijkstra wrote: ping Remove various MULS/MLAS patterns which are enabled when optimizing for  size.  However the codesize gain from these patterns is so minimal that  there is no point in keeping them. I disagree.

Re: [PATCH][ARM] Remove support for MULS

2019-09-18 Thread Kyrill Tkachov
Hi Wilco, On 9/9/19 6:07 PM, Wilco Dijkstra wrote: ping Remove various MULS/MLAS patterns which are enabled when optimizing for  size.  However the codesize gain from these patterns is so minimal that  there is no point in keeping them. I disagree. If they still trigger and generate better co

Re: [PATCH][ARM] Remove support for MULS

2019-09-09 Thread Wilco Dijkstra
ping   Remove various MULS/MLAS patterns which are enabled when optimizing for size.  However the codesize gain from these patterns is so minimal that there is no point in keeping them. Bootstrap OK on armhf, regress passes. ChangeLog: 2019-09-03  Wilco Dijkstra      * config/a

[PATCH][ARM] Remove support for MULS

2019-09-03 Thread Wilco Dijkstra
Remove various MULS/MLAS patterns which are enabled when optimizing for size. However the codesize gain from these patterns is so minimal that there is no point in keeping them. Bootstrap OK on armhf, regress passes. ChangeLog: 2019-09-03 Wilco Dijkstra * config/arm/arm.md (mulsi3_co