Re: [PATCH][GCC][AARCH64] Canonicalize aarch64 widening simd plus insns

2018-07-30 Thread Kyrill Tkachov
On 30/07/18 14:30, Christophe Lyon wrote: Hi, On Tue, 24 Jul 2018 at 17:39, Kyrill Tkachov wrote: On 24/07/18 16:12, James Greenhalgh wrote: On Thu, Jul 19, 2018 at 07:35:22AM -0500, Matthew Malcomson wrote: Hi again. Providing an updated patch to include the formatting suggestions.

Re: [PATCH][GCC][AARCH64] Canonicalize aarch64 widening simd plus insns

2018-07-30 Thread Christophe Lyon
Hi, On Tue, 24 Jul 2018 at 17:39, Kyrill Tkachov wrote: > > > On 24/07/18 16:12, James Greenhalgh wrote: > > On Thu, Jul 19, 2018 at 07:35:22AM -0500, Matthew Malcomson wrote: > > > Hi again. > > > > > > Providing an updated patch to include the formatting suggestions. > > > > Please try not to

Re: [PATCH][GCC][AARCH64] Canonicalize aarch64 widening simd plus insns

2018-07-24 Thread Kyrill Tkachov
On 24/07/18 16:12, James Greenhalgh wrote: On Thu, Jul 19, 2018 at 07:35:22AM -0500, Matthew Malcomson wrote: > Hi again. > > Providing an updated patch to include the formatting suggestions. Please try not to top-post replies, it makes the conversation thread harder to follow (reply

Re: [PATCH][GCC][AARCH64] Canonicalize aarch64 widening simd plus insns

2018-07-24 Thread James Greenhalgh
On Thu, Jul 19, 2018 at 07:35:22AM -0500, Matthew Malcomson wrote: > Hi again. > > Providing an updated patch to include the formatting suggestions. Please try not to top-post replies, it makes the conversation thread harder to follow (reply continues below!). > On 12/07/18 11:39, Sudakshina

Re: [PATCH][GCC][AARCH64] Canonicalize aarch64 widening simd plus insns

2018-07-19 Thread Matthew Malcomson
Hi again. Providing an updated patch to include the formatting suggestions. Thanks, Matthew On 12/07/18 11:39, Sudakshina Das wrote: Hi Matthew On 12/07/18 11:18, Richard Sandiford wrote: Looks good to me FWIW (not a maintainer), just a minor formatting thing: Matthew Malcomson writes:

Re: [PATCH][GCC][AARCH64] Canonicalize aarch64 widening simd plus insns

2018-07-12 Thread Sudakshina Das
Hi Matthew On 12/07/18 11:18, Richard Sandiford wrote: Looks good to me FWIW (not a maintainer), just a minor formatting thing: Matthew Malcomson writes: diff --git a/gcc/config/aarch64/aarch64-simd.md b/gcc/config/aarch64/aarch64-simd.md index

Re: [PATCH][GCC][AARCH64] Canonicalize aarch64 widening simd plus insns

2018-07-12 Thread Richard Sandiford
Looks good to me FWIW (not a maintainer), just a minor formatting thing: Matthew Malcomson writes: > diff --git a/gcc/config/aarch64/aarch64-simd.md > b/gcc/config/aarch64/aarch64-simd.md > index > aac5fa146ed8dde4507a0eb4ad6a07ce78d2f0cd..67b29cbe2cad91e031ee23be656ec61a403f2cf9 > 100644 >

[PATCH][GCC][AARCH64] Canonicalize aarch64 widening simd plus insns

2018-07-11 Thread Matthew Malcomson
Hi there, The current RTL patterns for widening addition and subtraction instructions in aarch64-simd.md use the code iterator attribute to make their definition more compact. This approach means that the `minus` and `plus` cases have their operands in the same order, which causes problems in