Re: [PATCH][PING][sanitizer/106558] asan: fix unsafe optimization of Asan checks.

2022-11-28 Thread Martin Liška
On 11/25/22 17:18, Martin Liška wrote: On 11/21/22 11:02, Jakub Jelinek wrote: Otherwise LGTM. Thanks and sorry for the review delay. Yuri, do you want to commit the patch soon? If not, I can help if you want? Hey. I've just installed the patch with function signature change and

Re: [PATCH][PING][sanitizer/106558] asan: fix unsafe optimization of Asan checks.

2022-11-25 Thread Martin Liška
On 11/21/22 11:02, Jakub Jelinek wrote: > Otherwise LGTM. Thanks and sorry for the review delay. Yuri, do you want to commit the patch soon? If not, I can help if you want? Cheers, Martin

Re: [PATCH][PING][sanitizer/106558] asan: fix unsafe optimization of Asan checks.

2022-11-21 Thread Jakub Jelinek via Gcc-patches
On Mon, Nov 21, 2022 at 12:57:15PM +0300, Yuri Gribov wrote: > From 4729f2db3f1b6b40ef0124e4a645788d7f66f426 Mon Sep 17 00:00:00 2001 > From: Yuri Gribov > Date: Sun, 14 Aug 2022 08:42:44 +0300 > Subject: [PATCH] asan: fix unsafe optimization of Asan checks. > > gcc/ > PR

[PATCH][PING][sanitizer/106558] asan: fix unsafe optimization of Asan checks.

2022-11-21 Thread Yuri Gribov via Gcc-patches
Hi, This patch fixes incorrect Asan optimization in https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106558 . It successfully passes bootstrap-asan, regular bootstrap and regression testing (on x86/amd64). With this patch number of optimizations has reduced only slightly (146062 -> 145824 on