Re: [PATCH][PING^2] Skip preprocessor directives in mklog

2015-05-12 Thread Diego Novillo
On Tue, May 12, 2015 at 11:50 AM, Tom de Vries tom_devr...@mentor.com wrote: I'm not a good choice to be the maintainer of a perl script. I'm all kinds of sorry about the original choice of scripting language. I'd just spend a couple of hours re-writing it in python.

Re: [PATCH][PING^2] Skip preprocessor directives in mklog

2015-05-12 Thread Yury Gribov
On 05/12/2015 06:57 PM, Trevor Saunders wrote: On Tue, May 12, 2015 at 06:33:28PM +0300, Yury Gribov wrote: On 05/12/2015 06:23 PM, Diego Novillo wrote: The patch looks fine to me. I'm not really involved in GCC development anymore. I would suggest that this script should be maintained by

Re: [PATCH][PING^2] Skip preprocessor directives in mklog

2015-05-12 Thread Jeff Law
On 05/12/2015 10:14 AM, Yury Gribov wrote: On 05/12/2015 06:57 PM, Trevor Saunders wrote: On Tue, May 12, 2015 at 06:33:28PM +0300, Yury Gribov wrote: On 05/12/2015 06:23 PM, Diego Novillo wrote: The patch looks fine to me. I'm not really involved in GCC development anymore. I would suggest

Re: [PATCH][PING^2] Skip preprocessor directives in mklog

2015-05-12 Thread Jeff Law
On 05/12/2015 09:19 AM, Yury Gribov wrote: On 04/30/2015 12:03 PM, Yury Gribov wrote: On 04/21/2015 02:26 PM, Yury Gribov wrote: Hi all, Contrib/mklog is currently faked by preprocessor directives inside functions to produce invalid ChangeLog. The attached patch fixes this. Tested with my

[PATCH][PING^2] Skip preprocessor directives in mklog

2015-05-12 Thread Yury Gribov
On 04/30/2015 12:03 PM, Yury Gribov wrote: On 04/21/2015 02:26 PM, Yury Gribov wrote: Hi all, Contrib/mklog is currently faked by preprocessor directives inside functions to produce invalid ChangeLog. The attached patch fixes this. Tested with my local mklog testsuite and

Re: [PATCH][PING^2] Skip preprocessor directives in mklog

2015-05-12 Thread Diego Novillo
The patch looks fine to me. I'm not really involved in GCC development anymore. I would suggest that this script should be maintained by whoever's been hacking on it the most. It's a simple script, so it shouldn't be hard to find a new maintainer for it. Diegop. On Tue, May 12, 2015 at 11:19

Re: [PATCH][PING^2] Skip preprocessor directives in mklog

2015-05-12 Thread Yury Gribov
On 05/12/2015 06:23 PM, Diego Novillo wrote: The patch looks fine to me. I'm not really involved in GCC development anymore. I would suggest that this script should be maintained by whoever's been hacking on it the most. It's a simple script, so it shouldn't be hard to find a new maintainer for

Re: [PATCH][PING^2] Skip preprocessor directives in mklog

2015-05-12 Thread Tom de Vries
On 12-05-15 17:33, Yury Gribov wrote: On 05/12/2015 06:23 PM, Diego Novillo wrote: The patch looks fine to me. I'm not really involved in GCC development anymore. I would suggest that this script should be maintained by whoever's been hacking on it the most. It's a simple script, so it

Re: [PATCH][PING^2] Skip preprocessor directives in mklog

2015-05-12 Thread Trevor Saunders
On Tue, May 12, 2015 at 06:33:28PM +0300, Yury Gribov wrote: On 05/12/2015 06:23 PM, Diego Novillo wrote: The patch looks fine to me. I'm not really involved in GCC development anymore. I would suggest that this script should be maintained by whoever's been hacking on it the most. It's a