Re: [PATCH][PR84213] DWARF: no location for non-definition DECLs with non-trivial DECL_VALUE_EXPR

2018-02-09 Thread Pierre-Marie de Rodat
On 02/09/2018 02:53 PM, Pierre-Marie de Rodat wrote: Pasto, or maybe I didn’t properly configure Vim on the machine I used. ;-) I’ll make sure these formatting issues are fixed before committing. Thanks! Committed! That was a Thunderbird pasto. I tried to update the PR. Hoping I did that

Re: [PATCH][PR84213] DWARF: no location for non-definition DECLs with non-trivial DECL_VALUE_EXPR

2018-02-09 Thread Pierre-Marie de Rodat
On 02/09/2018 02:47 PM, Richard Biener wrote: whitespace fixed here - vertical space missing before the comment and the first line of the comment (or cut error with the patch?) Pasto, or maybe I didn’t properly configure Vim on the machine I used. ;-) I’ll make sure these formatting issues

Re: [PATCH][PR84213] DWARF: no location for non-definition DECLs with non-trivial DECL_VALUE_EXPR

2018-02-09 Thread Richard Biener
On Fri, 9 Feb 2018, Pierre-Marie de Rodat wrote: > This patch restricts the set of cases in which we allow the generation of > location attributes for variables that are not defined in the current unit. > For such variables with complex DECL_VALUE_EXPR trees, generating a location > attribute can

[PATCH][PR84213] DWARF: no location for non-definition DECLs with non-trivial DECL_VALUE_EXPR

2018-02-09 Thread Pierre-Marie de Rodat
This patch restricts the set of cases in which we allow the generation of location attributes for variables that are not defined in the current unit. For such variables with complex DECL_VALUE_EXPR trees, generating a location attribute can end up creating relocations to text symbols in the