Re: Patch ping (Re: [PATCH][PR90106] Builtin call transformation changes in cdce pass)

2019-05-24 Thread Richard Biener
On Fri, 24 May 2019, Jakub Jelinek wrote: > On Fri, May 17, 2019 at 12:04:16AM +0200, Jakub Jelinek wrote: > > On Thu, May 16, 2019 at 11:39:38PM +0200, Jakub Jelinek wrote: > > > One possibility is to add -fdump-tree-optimized and scan for > > > /* { dg-final { scan-tree-dump "pow \\(\[^\n\r]*\\)

Patch ping (Re: [PATCH][PR90106] Builtin call transformation changes in cdce pass)

2019-05-24 Thread Jakub Jelinek
On Fri, May 17, 2019 at 12:04:16AM +0200, Jakub Jelinek wrote: > On Thu, May 16, 2019 at 11:39:38PM +0200, Jakub Jelinek wrote: > > One possibility is to add -fdump-tree-optimized and scan for > > /* { dg-final { scan-tree-dump "pow \\(\[^\n\r]*\\); \\\[tail call\\\]" > > "optimized" } } */ > > re

Re: [PATCH][PR90106] Builtin call transformation changes in cdce pass

2019-05-17 Thread Jakub Jelinek
On Fri, May 17, 2019 at 03:02:51PM +0800, JunMa wrote: > 2019-05-17  Jun Ma  > >     PR tree-optimization/90106 >     * gcc.dg/cdce3.c: New test. Ok, thanks. Jakub

Re: [PATCH][PR90106] Builtin call transformation changes in cdce pass

2019-05-17 Thread JunMa
在 2019/5/17 下午2:34, Jakub Jelinek 写道: On Fri, May 17, 2019 at 02:24:22PM +0800, JunMa wrote: 2019-05-17  Jun Ma Two spaces before < rather than one.     PR tree-optimization/90106     * gcc.dg/cdce3.c: New test. --- /dev/null +++ b/gcc/testsuite/gcc.dg/cdce3.c @@ -0,0 +1,12 @@ +/* { dg-do

Re: [PATCH][PR90106] Builtin call transformation changes in cdce pass

2019-05-16 Thread Jakub Jelinek
On Fri, May 17, 2019 at 02:24:22PM +0800, JunMa wrote: > 2019-05-17  Jun Ma Two spaces before < rather than one. >     PR tree-optimization/90106 >     * gcc.dg/cdce3.c: New test. > --- /dev/null > +++ b/gcc/testsuite/gcc.dg/cdce3.c > @@ -0,0 +1,12 @@ > +/* { dg-do compile } */ Just use one s

Re: [PATCH][PR90106] Builtin call transformation changes in cdce pass

2019-05-16 Thread JunMa
在 2019/5/17 上午11:09, JunMa 写道: 在 2019/5/17 上午6:04, Jakub Jelinek 写道: On Thu, May 16, 2019 at 11:39:38PM +0200, Jakub Jelinek wrote: One possibility is to add -fdump-tree-optimized and scan for /* { dg-final { scan-tree-dump "pow \\(\[^\n\r]*\\); \\\[tail call\\\]" "optimized" } } */ resp. /*

Re: [PATCH][PR90106] Builtin call transformation changes in cdce pass

2019-05-16 Thread JunMa
在 2019/5/17 上午6:04, Jakub Jelinek 写道: On Thu, May 16, 2019 at 11:39:38PM +0200, Jakub Jelinek wrote: One possibility is to add -fdump-tree-optimized and scan for /* { dg-final { scan-tree-dump "pow \\(\[^\n\r]*\\); \\\[tail call\\\]" "optimized" } } */ resp. /* { dg-final { scan-tree-dump "log

Re: [PATCH][PR90106] Builtin call transformation changes in cdce pass

2019-05-16 Thread Jakub Jelinek
On Thu, May 16, 2019 at 11:39:38PM +0200, Jakub Jelinek wrote: > One possibility is to add -fdump-tree-optimized and scan for > /* { dg-final { scan-tree-dump "pow \\(\[^\n\r]*\\); \\\[tail call\\\]" > "optimized" } } */ > resp. > /* { dg-final { scan-tree-dump "log \\(\[^\n\r]*\\); \\\[tail call\

Re: [PATCH][PR90106] Builtin call transformation changes in cdce pass

2019-05-16 Thread Jakub Jelinek
On Wed, May 08, 2019 at 06:09:06PM +0800, JunMa wrote: > 2019-05-07  Jun Ma > >     PR tree-optimization/90106 >     * gcc.dg/cdce1.c: Check tailcall code generation after cdce pass. >     * gcc.dg/cdce2.c: Likewise. This is wrong and results in UNSUPPORTED failures. Both tests are dg-do run, so

Re: [PATCH][PR90106] Builtin call transformation changes in cdce pass

2019-05-09 Thread JunMa
在 2019/5/10 上午4:00, Jeff Law 写道: On 5/8/19 8:25 PM, JunMa wrote: 在 2019/5/9 上午9:20, Bin.Cheng 写道: On Thu, May 9, 2019 at 5:31 AM Jeff Law wrote: On 5/8/19 6:28 AM, Richard Biener wrote: On Wed, May 8, 2019 at 12:09 PM JunMa wrote: Hi As PR90106 (https://gcc.gnu.org/bugzilla/show_bug.cgi?i

Re: [PATCH][PR90106] Builtin call transformation changes in cdce pass

2019-05-09 Thread Jeff Law
On 5/8/19 8:25 PM, JunMa wrote: > 在 2019/5/9 上午9:20, Bin.Cheng 写道: >> On Thu, May 9, 2019 at 5:31 AM Jeff Law wrote: >>> On 5/8/19 6:28 AM, Richard Biener wrote: On Wed, May 8, 2019 at 12:09 PM JunMa wrote: > Hi > > As PR90106 (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90106),

Re: [PATCH][PR90106] Builtin call transformation changes in cdce pass

2019-05-09 Thread Jeff Law
On 5/8/19 7:20 PM, Bin.Cheng wrote: > On Thu, May 9, 2019 at 5:31 AM Jeff Law wrote: >> >> On 5/8/19 6:28 AM, Richard Biener wrote: >>> On Wed, May 8, 2019 at 12:09 PM JunMa wrote: Hi As PR90106 (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90106), when gcc meets builtin

Re: [PATCH][PR90106] Builtin call transformation changes in cdce pass

2019-05-08 Thread JunMa
在 2019/5/9 上午9:20, Bin.Cheng 写道: On Thu, May 9, 2019 at 5:31 AM Jeff Law wrote: On 5/8/19 6:28 AM, Richard Biener wrote: On Wed, May 8, 2019 at 12:09 PM JunMa wrote: Hi As PR90106 (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90106), when gcc meets builtin function call like: y = sqrt

Re: [PATCH][PR90106] Builtin call transformation changes in cdce pass

2019-05-08 Thread Bin.Cheng
On Thu, May 9, 2019 at 5:31 AM Jeff Law wrote: > > On 5/8/19 6:28 AM, Richard Biener wrote: > > On Wed, May 8, 2019 at 12:09 PM JunMa wrote: > >> > >> Hi > >> > >> As PR90106 (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90106), > >> when gcc meets builtin function call like: > >> > >>y = sqr

Re: [PATCH][PR90106] Builtin call transformation changes in cdce pass

2019-05-08 Thread Jeff Law
On 5/8/19 6:28 AM, Richard Biener wrote: > On Wed, May 8, 2019 at 12:09 PM JunMa wrote: >> >> Hi >> >> As PR90106 (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90106), >> when gcc meets builtin function call like: >> >>y = sqrt (x); >> >> The cdce pass tries to transform the call into an inter

Re: [PATCH][PR90106] Builtin call transformation changes in cdce pass

2019-05-08 Thread Richard Biener
On Wed, May 8, 2019 at 12:09 PM JunMa wrote: > > Hi > > As PR90106 (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90106), > when gcc meets builtin function call like: > >y = sqrt (x); > > The cdce pass tries to transform the call into an internal function > call and conditionally executes call

[PATCH][PR90106] Builtin call transformation changes in cdce pass

2019-05-08 Thread JunMa
Hi As PR90106 (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90106), when gcc meets builtin function call like:   y = sqrt (x); The cdce pass tries to transform the call into an internal function call and conditionally executes call with a simple range check on the arguments which can detect mos