Re: [PATCH] #undef isblank before def or decl in libstdc++ headers

2021-12-13 Thread Olivier Hainque via Gcc-patches
> On 11 Dec 2021, at 18:09, Jonathan Wakely wrote: > > * config/vxworks.h (VXWORKS_OS_CPP_BUILTINS): Define > _C99 for C++. > > Makes sense? > > Yes. I can't approve patches outside libstdc++, but that looks definitely > correct for C++11 and later, because C++11 incorporate

Re: [PATCH] #undef isblank before def or decl in libstdc++ headers

2021-12-11 Thread Jonathan Wakely via Gcc-patches
On Sat, 11 Dec 2021, 10:56 Olivier Hainque via Libstdc++, < libstd...@gcc.gnu.org> wrote: > (Thanks for your feedback Jonathan) > > > On 10 Dec 2021, at 19:24, Jonathan Wakely wrote: > > > > I'm curious why _GLIBCXX_USE_C99_CTYPE_TR1 is not defined if VxWorks > > has isblank, the configure check

Re: [PATCH] #undef isblank before def or decl in libstdc++ headers

2021-12-11 Thread Olivier Hainque via Gcc-patches
(Thanks for your feedback Jonathan) > On 10 Dec 2021, at 19:24, Jonathan Wakely wrote: > > I'm curious why _GLIBCXX_USE_C99_CTYPE_TR1 is not defined if VxWorks > has isblank, the configure check is: Oh, hmm, very good point. The reason was that the definition of isblank is conditioned on _C99/_

Re: [PATCH] #undef isblank before def or decl in libstdc++ headers

2021-12-10 Thread Jonathan Wakely via Gcc-patches
On Fri, 10 Dec 2021 at 17:07, Olivier Hainque via Libstdc++ wrote: > > Hello, > > The attached patch helps fix a build failure of libstdc++ > on some variants of VxWorks where the system headers expose > an "isblank" macro. > > I understand this kind of thing normally is handled through > fixinclu

[PATCH] #undef isblank before def or decl in libstdc++ headers

2021-12-10 Thread Olivier Hainque via Gcc-patches
Hello, The attached patch helps fix a build failure of libstdc++ on some variants of VxWorks where the system headers expose an "isblank" macro. I understand this kind of thing normally is handled through fixincludes, however fixincludes on VxWorks is very tricky and we already have libstdc++-