Re: [PATCH] [GOMP4] OpenACC 1.0+ support in fortran front-end

2014-01-31 Thread Ilmir Usmanov
Hi Thomas! I fixed these patches: http://gcc.gnu.org/ml/gcc-patches/2014-01/msg01520.html . Instead of adding new OACC_* data structures and macros for OpenACC clauses these patches reuse existing OMP_* functionality and extends it. But OpenACC-specific constructs and directives still named

Re: [PATCH] [GOMP4] OpenACC 1.0+ support in fortran front-end

2014-01-27 Thread Ilmir Usmanov
Hi, Thomas! Likewise, if you have any comments on my patch series for »initial support for OpenACC data clauses«, I'd like to hear them. Sure: + else if (!strcmp (present_or_copy, p)) +result = PRAGMA_OMP_CLAUSE_PRESENT_OR_COPY; + else if (!strcmp (present_or_copyin, p)) +

Re: [PATCH] [GOMP4] OpenACC 1.0+ support in fortran front-end

2014-01-27 Thread Ilmir Usmanov
Hi, Thomas! Thank you for your review. I agree with all your notes. I'm going to reuse your implementation of data clauses, add minimal GIMPLE infrastructure, and then resend patches. -- Ilmir.

Re: [PATCH] [GOMP4] OpenACC 1.0+ support in fortran front-end

2014-01-27 Thread Thomas Schwinge
Hi! On Mon, 27 Jan 2014 17:12:04 +0400, Ilmir Usmanov i.usma...@samsung.com wrote: Thank you for your review. You're welcome. Hopefully the merge from trunk into gomp-4_0-branch that I just committed doesn't cause you additional work -- but as I told in my other email, there were no conflicts

Re: [PATCH] [GOMP4] OpenACC 1.0+ support in fortran front-end

2014-01-24 Thread Thomas Schwinge
Hi! On Thu, 23 Jan 2014 22:01:19 +0400, Ilmir Usmanov i.usma...@samsung.com wrote: Jakub, could you review these patches, if they are OK to gomp-4_0-branch? Thomas, please, have a look whether this implementation applies current OpenACC support style. So, in context of

[PATCH] [GOMP4] OpenACC 1.0+ support in fortran front-end

2014-01-23 Thread Ilmir Usmanov
Hi all. Jakub, could you review these patches, if they are OK to gomp-4_0-branch? Thomas, please, have a look whether this implementation applies current OpenACC support style. These patches port OpenACC 1.0 support in fortran front-end from openacc-1_0-branch to gomp-4_0-branch. In