Re: [PATCH] [MSP430] Fix gcc.dg/pr85180.c and gcc.dg/pr87985.c timeouts for msp430-elf -mlarge

2018-12-18 Thread Jozef Lawrynowicz
On Tue, 18 Dec 2018 03:08:51 -0600 Segher Boessenkool wrote: > Hi! > > On Fri, Dec 14, 2018 at 03:22:13PM +, Jozef Lawrynowicz wrote: > > 2018-12-14 Jozef Lawrynowicz > > > > gcc/ChangeLog: > > * combine.c (update_rsp_from_reg_equal): Only look for the nonzero bits > > of

Re: [PATCH] [MSP430] Fix gcc.dg/pr85180.c and gcc.dg/pr87985.c timeouts for msp430-elf -mlarge

2018-12-18 Thread Segher Boessenkool
Hi! On Fri, Dec 14, 2018 at 03:22:13PM +, Jozef Lawrynowicz wrote: > 2018-12-14 Jozef Lawrynowicz > > gcc/ChangeLog: > * combine.c (update_rsp_from_reg_equal): Only look for the nonzero bits > of src in nonzero_bits_mode if the mode of src is MODE_INT and >

Re: [PATCH] [MSP430] Fix gcc.dg/pr85180.c and gcc.dg/pr87985.c timeouts for msp430-elf -mlarge

2018-12-14 Thread Jozef Lawrynowicz
Hi Segher, Thanks for the review. On Wed, 12 Dec 2018 19:47:53 -0600 Segher Boessenkool wrote: > The unused bits in a MODE_PARTIAL_INT value are undefined, so nonzero_bits > isn't valid for conversion in either direction. > > And *which* bits are undefined isn't defined anywhere either, so we

Re: [PATCH] [MSP430] Fix gcc.dg/pr85180.c and gcc.dg/pr87985.c timeouts for msp430-elf -mlarge

2018-12-12 Thread Segher Boessenkool
On Wed, Dec 12, 2018 at 12:09:19PM +, Jozef Lawrynowicz wrote: > Compilation of gcc.dg/pr85180.c and gcc.dg/pr87985.c times out after 5 minutes > for msp430 with -mlarge. > > nonzero_bits1 (from rtlanal.c), recurses many times for each reg > because reg_nonzero_bits_for_combine (combine.c)

[PATCH] [MSP430] Fix gcc.dg/pr85180.c and gcc.dg/pr87985.c timeouts for msp430-elf -mlarge

2018-12-12 Thread Jozef Lawrynowicz
Compilation of gcc.dg/pr85180.c and gcc.dg/pr87985.c times out after 5 minutes for msp430 with -mlarge. nonzero_bits1 (from rtlanal.c), recurses many times for each reg because reg_nonzero_bits_for_combine (combine.c) never considers using last_set_nonzero_bits for the given reg when the reg is