Re: [PATCH] [PR79542][Ada] Fix ICE in dwarf2out.c with nested func. inlining

On 09/04/2017 11:26 AM, Richard Biener wrote: No more pending issues and yes, I guess the fix is ok for the branch. Ok, thanks! This is now comitted on the 7 release branch. -- Pierre-Marie de Rodat

Re: [PATCH] [PR79542][Ada] Fix ICE in dwarf2out.c with nested func. inlining

On Mon, Sep 4, 2017 at 11:20 AM, Pierre-Marie de Rodat wrote: > On 08/18/2017 12:10 PM, Richard Biener wrote: >>> >>> ok, not doing this at all doesn't work, doing it only in the above case >>> neither. >>> >>> Bah. >>> >>> Can anyone explain to me why we do the

Re: [PATCH] [PR79542][Ada] Fix ICE in dwarf2out.c with nested func. inlining

On 08/18/2017 12:10 PM, Richard Biener wrote: ok, not doing this at all doesn't work, doing it only in the above case neither. Bah. Can anyone explain to me why we do the set_decl_origin_self dance? Ok, so I need the following incremental patch to fix the fallout. This allows Ada LTO

Re: [PATCH] [PR79542][Ada] Fix ICE in dwarf2out.c with nested func. inlining

On Tue, Aug 15, 2017 at 1:16 PM, Richard Biener wrote: > On Sat, Aug 12, 2017 at 11:09 AM, Pierre-Marie de Rodat > wrote: >> On 08/11/2017 11:29 PM, Jason Merrill wrote: >>> >>> OK. >> >> >> Committed. Thank you for your sustained review effort,

Re: [PATCH] [PR79542][Ada] Fix ICE in dwarf2out.c with nested func. inlining

On Sat, Aug 12, 2017 at 11:09 AM, Pierre-Marie de Rodat wrote: > On 08/11/2017 11:29 PM, Jason Merrill wrote: >> >> OK. > > > Committed. Thank you for your sustained review effort, Jason. :-) The way you use decl_ultimate_origin conflicts with the early LTO debug patches

Re: [PATCH] [PR79542][Ada] Fix ICE in dwarf2out.c with nested func. inlining

On 08/11/2017 11:29 PM, Jason Merrill wrote: OK. Committed. Thank you for your sustained review effort, Jason. :-) -- Pierre-Marie de Rodat

Re: [PATCH] [PR79542][Ada] Fix ICE in dwarf2out.c with nested func. inlining

On Fri, Aug 11, 2017 at 6:05 AM, Pierre-Marie de Rodat wrote: > On 08/07/2017 08:42 PM, Jason Merrill wrote: >> >> Perhaps the DECL_ABSTRACT_ORIGIN check in my patch should be >> decl_ultimate_origin instead, which should return null in that case? > > > It looks like it

Re: [PATCH] [PR79542][Ada] Fix ICE in dwarf2out.c with nested func. inlining

rom 9272d97bfa77b073d57e99c231d271ec1bea2c26 Mon Sep 17 00:00:00 2001 From: Pierre-Marie de Rodat <dero...@adacore.com> Date: Tue, 9 May 2017 12:24:36 +0200 Subject: [PATCH] [PR79542][Ada] Fix ICE in dwarf2out.c with nested func. inlining https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79542 reports an ICE in dwarf2out.c f

Re: [PATCH] [PR79542][Ada] Fix ICE in dwarf2out.c with nested func. inlining

On 05/26/2017 10:12 AM, Pierre-Marie de Rodat wrote: On 05/08/2017 06:27 PM, Jason Merrill wrote: That seems like a bug; if gen_typedef_die is going to generate a DIE for a cloned typedef, it needs to associate the type with the DIE. Hm… gen_typedef_die generates a DIE for a DECL node, but

[PING*3][PATCH] [PR79542][Ada] Fix ICE in dwarf2out.c with nested func. inlining

Hello, Ping for the updated patch, originally submitted at . Thank you in advance! -- Pierre-Marie de Rodat

[PING*2][PATCH] [PR79542][Ada] Fix ICE in dwarf2out.c with nested func. inlining

I would like to ping for the updated patch, originally submitted at . Thank you in advance! -- Pierre-Marie de Rodat

Re: [PATCH] [PR79542][Ada] Fix ICE in dwarf2out.c with nested func. inlining

On 05/26/2017 04:12 PM, Pierre-Marie de Rodat wrote: I tried this, but I got a crash when compiling the Ada runtime (g-awk.adb). I could not extract a reproducer, but the idea is that because of the call to set_decl_origin_self, some DECLs have themselves as DECL_ABSTRACT_ORIGIN. As a result,

Re: [PATCH] [PR79542][Ada] Fix ICE in dwarf2out.c with nested func. inlining

ATCH] [PR79542][Ada] Fix ICE in dwarf2out.c with nested func. inlining https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79542 reports an ICE in dwarf2out.c for an Ada testcase built with optimization. This crash happens during the late generation pass because add_gnat_descriptive_type canno

Re: [PATCH] [PR79542][Ada] Fix ICE in dwarf2out.c with nested func. inlining

On Wed, May 3, 2017 at 3:22 PM, Jason Merrill wrote: > On Tue, Mar 14, 2017 at 8:24 AM, Pierre-Marie de Rodat > wrote: >> Hello, >> >> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79542 reports an ICE in >> dwarf2out.c for an Ada testcase built with

Re: [PATCH] [PR79542][Ada] Fix ICE in dwarf2out.c with nested func. inlining

On Tue, Mar 14, 2017 at 8:24 AM, Pierre-Marie de Rodat wrote: > Hello, > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79542 reports an ICE in > dwarf2out.c for an Ada testcase built with optimization. > > This crash happens during the late generation pass because >

[PING*2][PATCH][PR79542][Ada] Fix ICE in dwarf2out.c with nested func. inlining

Hello, I would like to ping for the patch I posted there: . Thank you! -- Pierre-Marie de Rodat

[PING][PATCH][PR79542][Ada] Fix ICE in dwarf2out.c with nested func. inlining

Hello, This is a ping for the patch I posted there: . Thank you! -- Pierre-Marie de Rodat

[PATCH] [PR79542][Ada] Fix ICE in dwarf2out.c with nested func. inlining

Hello, https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79542 reports an ICE in dwarf2out.c for an Ada testcase built with optimization. This crash happens during the late generation pass because add_gnat_descriptive_type cannot find the type DIE corresponding to some descriptive type after having