Re: [PATCH] [testsuite] Fix pretty printers regexps for GDB output

2024-04-11 Thread Jonathan Wakely
On Thu, 25 Jan 2024 at 15:54, Christophe Lyon wrote: > > On Wed, 24 Jan 2024 at 12:02, Jonathan Wakely wrote: > > > > On Wed, 24 Jan 2024 at 10:48, Christophe Lyon wrote: > > > > > > GDB emits end of lines as \r\n, we currently match the reverse \n\r, > > > > We currently match [\n\r]+ which

Re: [PATCH] [testsuite] Fix pretty printers regexps for GDB output

2024-04-10 Thread Christophe Lyon
ping? On Tue, 6 Feb 2024 at 10:26, Christophe Lyon wrote: > > ping? > > On Thu, 25 Jan 2024 at 16:54, Christophe Lyon > wrote: > > > > On Wed, 24 Jan 2024 at 12:02, Jonathan Wakely wrote: > > > > > > On Wed, 24 Jan 2024 at 10:48, Christophe Lyon wrote: > > > > > > > > GDB emits end of lines as

Re: [PATCH] [testsuite] Fix pretty printers regexps for GDB output

2024-02-06 Thread Christophe Lyon
ping? On Thu, 25 Jan 2024 at 16:54, Christophe Lyon wrote: > > On Wed, 24 Jan 2024 at 12:02, Jonathan Wakely wrote: > > > > On Wed, 24 Jan 2024 at 10:48, Christophe Lyon wrote: > > > > > > GDB emits end of lines as \r\n, we currently match the reverse \n\r, > > > > We currently match [\n\r]+

Re: [PATCH] [testsuite] Fix pretty printers regexps for GDB output

2024-01-25 Thread Christophe Lyon
On Wed, 24 Jan 2024 at 12:02, Jonathan Wakely wrote: > > On Wed, 24 Jan 2024 at 10:48, Christophe Lyon wrote: > > > > GDB emits end of lines as \r\n, we currently match the reverse \n\r, > > We currently match [\n\r]+ which should match any of \n, \r, \n\r or \r\n > Hmm, right, sorry I had this

Re: [PATCH] [testsuite] Fix pretty printers regexps for GDB output

2024-01-24 Thread Jonathan Wakely
On Wed, 24 Jan 2024 at 10:48, Christophe Lyon wrote: > > GDB emits end of lines as \r\n, we currently match the reverse \n\r, We currently match [\n\r]+ which should match any of \n, \r, \n\r or \r\n > possibly leading to mismatches under racy conditions. What do we incorrectly match? Is the

[PATCH] [testsuite] Fix pretty printers regexps for GDB output

2024-01-24 Thread Christophe Lyon
GDB emits end of lines as \r\n, we currently match the reverse \n\r, possibly leading to mismatches under racy conditions. I noticed this while running the GCC testsuite using the equivalent of GDB's READ1 feature [1] which helps detecting bufferization issues. Adjusting the first regexp to