Re: [PATCH] ARM/NEON: vld1q_dup_s64 builtin

2012-06-25 Thread Ramana Radhakrishnan
On 22 June 2012 18:58, Ramana Radhakrishnan ramana.radhakrish...@linaro.org wrote: On 20 June 2012 14:37, Christophe Lyon christophe.l...@st.com wrote: On 06.06.2012 11:00, Ramana Radhakrishnan wrote: Ok with those changes. Ramana . Hi Ramana, How about this version? Christophe. OK  

Re: [PATCH] ARM/NEON: vld1q_dup_s64 builtin

2012-06-22 Thread Ramana Radhakrishnan
On 20 June 2012 14:37, Christophe Lyon christophe.l...@st.com wrote: On 06.06.2012 11:00, Ramana Radhakrishnan wrote: Ok with those changes. Ramana . Hi Ramana, How about this version? Christophe. OK - This should also go into the release branches as it fixes wrong code with an

Re: [PATCH] ARM/NEON: vld1q_dup_s64 builtin

2012-06-20 Thread Christophe Lyon
On 06.06.2012 11:00, Ramana Radhakrishnan wrote: Ok with those changes. Ramana . Hi Ramana, How about this version? Christophe. commit f57ce4b63ca1c30ee88e8c1a431d6e90ffbecb82 Author: Christophe Lyon christophe.l...@st.com Date: Wed Jun 20 15:30:50 2012 +0200 2012-06-20 Christophe

Re: [PATCH] ARM/NEON: vld1q_dup_s64 builtin

2012-06-06 Thread Ramana Radhakrishnan
Hi Christophe, Sorry it's taken me a while to get back on this patch - I've been traveling. diff --git a/gcc/config/arm/neon.md b/gcc/config/arm/neon.md index 4568dea..0a4d00b 100644 --- a/gcc/config/arm/neon.md +++ b/gcc/config/arm/neon.md @@ -4397,20 +4397,32 @@ ) (define_insn

Re: [PATCH] ARM/NEON: vld1q_dup_s64 builtin

2012-05-25 Thread Christophe Lyon
On 21.05.2012 11:16, Christophe Lyon wrote: I tried applying your patch but ran into trouble with patch not liking this . My suspicion is mailer munging white spaces in some form - Could you send the patch as an attachment please rather than inline in your mail ? regards, Ramana Here it is,

Re: [PATCH] ARM/NEON: vld1q_dup_s64 builtin

2012-05-21 Thread Christophe Lyon
I tried applying your patch but ran into trouble with patch not liking this . My suspicion is mailer munging white spaces in some form - Could you send the patch as an attachment please rather than inline in your mail ? regards, Ramana Here it is, as an attachment. Note however that this patch

Re: [PATCH] ARM/NEON: vld1q_dup_s64 builtin

2012-05-11 Thread Ramana Radhakrishnan
You also don't mention how this patch was tested. I used the testsuite I developed some time ago to test all the Neon builtins, which I posted last year on the qemu mailing-list. With the current GCCs, this bug is the only remaining one I could detect. Fair enough.  Alternatively it

Re: [PATCH] ARM/NEON: vld1q_dup_s64 builtin

2012-05-10 Thread Ramana Radhakrishnan
On 9 May 2012 11:18, Christophe Lyon christophe.l...@st.com wrote: Hello, On ARM+Neon, the expansion of vld1q_dup_s64() and vld1q_dup_u64() builtins currently fails to load the second vector element. Thanks for the patch but this is not acceptable as it stands today. You need to set the

Re: [PATCH] ARM/NEON: vld1q_dup_s64 builtin

2012-05-10 Thread Christophe Lyon
On 10.05.2012 13:41, Ramana Radhakrishnan wrote: On 9 May 2012 11:18, Christophe Lyonchristophe.l...@st.com wrote: Hello, On ARM+Neon, the expansion of vld1q_dup_s64() and vld1q_dup_u64() builtins currently fails to load the second vector element. Thanks for the patch but this is not

Re: [PATCH] ARM/NEON: vld1q_dup_s64 builtin

2012-05-10 Thread Julian Brown
On Thu, 10 May 2012 17:31:43 +0200 Christophe Lyon christophe.l...@st.com wrote: On 10.05.2012 13:41, Ramana Radhakrishnan wrote: On 9 May 2012 11:18, Christophe Lyonchristophe.l...@st.com wrote: Hello, On ARM+Neon, the expansion of vld1q_dup_s64() and vld1q_dup_u64() builtins

[PATCH] ARM/NEON: vld1q_dup_s64 builtin

2012-05-09 Thread Christophe Lyon
Hello, On ARM+Neon, the expansion of vld1q_dup_s64() and vld1q_dup_u64() builtins currently fails to load the second vector element. Here is a small patch to address this problem: 2012-05-07 Christophe Lyon christophe.l...@st.com * gcc/config/arm/neon.md (neon_vld1_dup): Fix