Re: [PATCH] Add generic support for "noinit" attribute

2019-08-14 Thread Christophe Lyon
t; > -Original Message- > > From: gcc-patches-ow...@gcc.gnu.org On > > Behalf Of Christophe Lyon > > Sent: Wednesday, August 14, 2019 2:18 PM > > To: Christophe Lyon ; Martin Sebor > > ; gcc Patches ; Richard Earnshaw > > ; ni...@redhat.com; Jozef La

Re: [PATCH] Add generic support for "noinit" attribute

2019-08-14 Thread Christophe Lyon
tin Sebor > ; gcc Patches ; Richard Earnshaw > ; ni...@redhat.com; Jozef Lawrynowicz > ; Richard Sandiford > Subject: Re: [PATCH] Add generic support for "noinit" attribute > > On Wed, 14 Aug 2019 at 14:14, Richard Sandiford > wrote: > > > > Sorry for

RE: [PATCH] Add generic support for "noinit" attribute

2019-08-14 Thread Tamar Christina
; gcc Patches ; Richard Earnshaw ; ni...@redhat.com; Jozef Lawrynowicz ; Richard Sandiford Subject: Re: [PATCH] Add generic support for "noinit" attribute On Wed, 14 Aug 2019 at 14:14, Richard Sandiford wrote: > > Sorry for the slow response, I'd missed that there was

Re: [PATCH] Add generic support for "noinit" attribute

2019-08-14 Thread Christophe Lyon
On Wed, 14 Aug 2019 at 14:14, Richard Sandiford wrote: > > Sorry for the slow response, I'd missed that there was an updated patch... > > Christophe Lyon writes: > > 2019-07-04 Christophe Lyon > > > > * lib/target-supports.exp (check_effective_target_noinit): New > > proc. > >

Re: [PATCH] Add generic support for "noinit" attribute

2019-08-14 Thread Richard Sandiford
Sorry for the slow response, I'd missed that there was an updated patch... Christophe Lyon writes: > 2019-07-04 Christophe Lyon > > * lib/target-supports.exp (check_effective_target_noinit): New > proc. > * gcc.c-torture/execute/noinit-attribute.c: New test.

Re: [PATCH] Add generic support for "noinit" attribute

2019-08-13 Thread Christophe Lyon
Ping? On Tue, 30 Jul 2019 at 15:35, Christophe Lyon wrote: > > Hi, > > Thanks for the useful feedback. > > > On Tue, 16 Jul 2019 at 11:54, Richard Sandiford > wrote: > > > > Thanks for doing this in a generic way. > > > > Christophe Lyon writes: > > > @@ -2224,6 +2234,50 @@

Re: [PATCH] Add generic support for "noinit" attribute

2019-08-12 Thread Jozef Lawrynowicz
Hi, On Tue, 30 Jul 2019 15:35:23 +0200 Christophe Lyon wrote: > Hi, > > Thanks for the useful feedback. > > > On Tue, 16 Jul 2019 at 11:54, Richard Sandiford > wrote: > > > > Thanks for doing this in a generic way. > > > > Christophe Lyon writes: > > > @@ -2224,6 +2234,50 @@

Re: [PATCH] Add generic support for "noinit" attribute

2019-07-30 Thread Christophe Lyon
Hi, Thanks for the useful feedback. On Tue, 16 Jul 2019 at 11:54, Richard Sandiford wrote: > > Thanks for doing this in a generic way. > > Christophe Lyon writes: > > @@ -2224,6 +2234,50 @@ handle_weak_attribute (tree *node, tree name, > >return NULL_TREE; > > } > > > > +/* Handle a

Re: [PATCH] Add generic support for "noinit" attribute

2019-07-16 Thread Richard Sandiford
Thanks for doing this in a generic way. Christophe Lyon writes: > @@ -2224,6 +2234,50 @@ handle_weak_attribute (tree *node, tree name, >return NULL_TREE; > } > > +/* Handle a "noinit" attribute; arguments as in struct > + attribute_spec.handler. Check whether the attribute is allowed >

Re: [PATCH] Add generic support for "noinit" attribute

2019-07-16 Thread Christophe Lyon
Ping? Le mar. 9 juil. 2019 à 00:04, Martin Sebor a écrit : > On 7/8/19 5:10 AM, Christophe Lyon wrote: > > On Sat, 6 Jul 2019 at 19:57, Martin Sebor wrote: > >> > >> On 7/4/19 9:27 AM, Christophe Lyon wrote: > >>> Hi, > >>> > >>> Similar to what already exists for TI msp430 or in TI compilers

Re: [PATCH] Add generic support for "noinit" attribute

2019-07-08 Thread Martin Sebor
On 7/8/19 5:10 AM, Christophe Lyon wrote: On Sat, 6 Jul 2019 at 19:57, Martin Sebor wrote: On 7/4/19 9:27 AM, Christophe Lyon wrote: Hi, Similar to what already exists for TI msp430 or in TI compilers for arm, this patch adds support for the "noinit" attribute. It is convenient for

Re: [PATCH] Add generic support for "noinit" attribute

2019-07-08 Thread Christophe Lyon
On Sat, 6 Jul 2019 at 19:57, Martin Sebor wrote: > > On 7/4/19 9:27 AM, Christophe Lyon wrote: > > Hi, > > > > Similar to what already exists for TI msp430 or in TI compilers for > > arm, this patch adds support for the "noinit" attribute. > > > > It is convenient for embedded targets where the

Re: [PATCH] Add generic support for "noinit" attribute

2019-07-06 Thread Martin Sebor
On 7/4/19 9:27 AM, Christophe Lyon wrote: Hi, Similar to what already exists for TI msp430 or in TI compilers for arm, this patch adds support for the "noinit" attribute. It is convenient for embedded targets where the user wants to keep the value of some data when the program is restarted:

Re: [PATCH] Add generic support for "noinit" attribute

2019-07-05 Thread Christophe Lyon
On Fri, 5 Jul 2019 at 12:57, Jozef Lawrynowicz wrote: > > On Fri, 5 Jul 2019 11:26:20 +0200 > Christophe Lyon wrote: > > > On Thu, 4 Jul 2019 at 23:46, Jozef Lawrynowicz > > wrote: > > > > > > Also, the gcc.target/arm/noinit-attribute.c test works with msp430. > > > Why not create a

Re: [PATCH] Add generic support for "noinit" attribute

2019-07-05 Thread Jozef Lawrynowicz
On Fri, 5 Jul 2019 11:26:20 +0200 Christophe Lyon wrote: > On Thu, 4 Jul 2019 at 23:46, Jozef Lawrynowicz > wrote: > > > > Also, the gcc.target/arm/noinit-attribute.c test works with msp430. > > Why not create a effective-target keyword which checks for noinit support, > > so > > the test can

Re: [PATCH] Add generic support for "noinit" attribute

2019-07-05 Thread Christophe Lyon
On Thu, 4 Jul 2019 at 23:46, Jozef Lawrynowicz wrote: > > Hi, > > > diff --git a/gcc/config/msp430/msp430.c b/gcc/config/msp430/msp430.c > > index 365e9eb..8266fa0 100644 > > --- a/gcc/config/msp430/msp430.c > > +++ b/gcc/config/msp430/msp430.c > > @@ -1807,7 +1807,6 @@ const char * const

Re: [PATCH] Add generic support for "noinit" attribute

2019-07-04 Thread Jozef Lawrynowicz
Hi, > diff --git a/gcc/config/msp430/msp430.c b/gcc/config/msp430/msp430.c > index 365e9eb..8266fa0 100644 > --- a/gcc/config/msp430/msp430.c > +++ b/gcc/config/msp430/msp430.c > @@ -1807,7 +1807,6 @@ const char * const ATTR_CRIT = "critical"; > const char * const ATTR_LOWER = "lower"; >

Re: [PATCH] Add generic support for "noinit" attribute

2019-07-04 Thread Jozef Lawrynowicz
On Thu, 4 Jul 2019 17:27:28 +0200 Christophe Lyon wrote: > Finally, I tested on arm-eabi, but not on msp430 for which I do not > have the environment, so advice from msp430 maintainers is > appreciated. Since msp430 does not use the same default helpers as > arm, I left the "noinit" handling

[PATCH] Add generic support for "noinit" attribute

2019-07-04 Thread Christophe Lyon
Hi, Similar to what already exists for TI msp430 or in TI compilers for arm, this patch adds support for the "noinit" attribute. It is convenient for embedded targets where the user wants to keep the value of some data when the program is restarted: such variables are not zero-initialized. It is