Re: [PATCH] Added noexcept on constructors

2016-12-06 Thread Ville Voutilainen
On 6 December 2016 at 18:23, Aditya Kumar wrote: > Since g++ correctly finds this error, I'm wondering how > libstdc++-v3/src/c++11/shared_ptr.cc was compiling correctly before. Presumably because it wasn't built with __GTHREADS defined?

RE: [PATCH] Added noexcept on constructors

2016-12-06 Thread Aditya Kumar
December 06, 2016 4:26 AM To: Aditya Kumar Cc: gcc-patches@gcc.gnu.org; libstd...@gcc.gnu.org; ville.voutilai...@gmail.com Subject: Re: [PATCH] Added noexcept on constructors On 05/12/16 15:34 -0600, Aditya Kumar wrote: >Thanks for the feedback. Updated patch is below. > > >The noexcept

Re: [PATCH] Added noexcept on constructors

2016-12-06 Thread Jonathan Wakely
On 05/12/16 15:34 -0600, Aditya Kumar wrote: Thanks for the feedback. Updated patch is below. The noexcept on definition and the declaration of constructors _Sp_locker do not match. Thanks for the patch (and thanks, Ville, for reviewing it). I'll commit this today.

[PATCH] Added noexcept on constructors

2016-12-05 Thread Aditya Kumar
Thanks for the feedback. Updated patch is below. The noexcept on definition and the declaration of constructors _Sp_locker do not match. ChangeLog 2016-12-05 Aditya Kumar * src/c++11/shared_ptr.cc (_Sp_locker::_Sp_locker(const void* p)): Added noexcept on constructors.

Re: [PATCH] Added noexcept on constructors

2016-12-03 Thread Ville Voutilainen
On 3 December 2016 at 14:20, Ville Voutilainen wrote: > On 3 December 2016 at 13:31, Aditya K wrote: >> --- >> libstdc++-v3/ChangeLog | 3 +++ >> libstdc++-v3/src/c++11/shared_ptr.cc | 4 ++-- >> 2 files changed, 5 insertions(+), 2 deletions(-) >> >> diff --git a/libstdc++-v3/Chang

Re: [PATCH] Added noexcept on constructors

2016-12-03 Thread Ville Voutilainen
On 3 December 2016 at 13:31, Aditya K wrote: > --- > libstdc++-v3/ChangeLog | 3 +++ > libstdc++-v3/src/c++11/shared_ptr.cc | 4 ++-- > 2 files changed, 5 insertions(+), 2 deletions(-) > > diff --git a/libstdc++-v3/ChangeLog b/libstdc++-v3/ChangeLog > index 08d9229..18924c4 100644 >

[PATCH] Added noexcept on constructors

2016-12-03 Thread Aditya K
--- libstdc++-v3/ChangeLog | 3 +++ libstdc++-v3/src/c++11/shared_ptr.cc | 4 ++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/libstdc++-v3/ChangeLog b/libstdc++-v3/ChangeLog index 08d9229..18924c4 100644 --- a/libstdc++-v3/ChangeLog +++ b/libstdc++-v3/ChangeLog @@