Re: [PATCH] Allow USE in PARALLELs in store_data_bypass_p (take 2)

2017-12-11 Thread Eric Botcazou
> The old code was inconsistent, had return false; in one case and assert in > the remaining two spots. If you are not against it, I'd use return false; > in both cases if we want consistency. Sure, thanks. -- Eric Botcazou

Re: [PATCH] Allow USE in PARALLELs in store_data_bypass_p (take 2)

2017-12-11 Thread Jakub Jelinek
On Mon, Dec 11, 2017 at 01:26:42PM +0100, Eric Botcazou wrote: > > Ah, that makes a lot of sense. So like this? > > > > 2017-12-11 Jakub Jelinek > > > > * recog.c (store_data_bypass_p_1): New function. > > (store_data_bypass_p): Handle USE in a PARALLEL like CLOBBER. Use > > stor

Re: [PATCH] Allow USE in PARALLELs in store_data_bypass_p (take 2)

2017-12-11 Thread Eric Botcazou
> Ah, that makes a lot of sense. So like this? > > 2017-12-11 Jakub Jelinek > > * recog.c (store_data_bypass_p_1): New function. > (store_data_bypass_p): Handle USE in a PARALLEL like CLOBBER. Use > store_data_bypass_p_1 to avoid code duplication. Formatting fixes. Yes, b

[PATCH] Allow USE in PARALLELs in store_data_bypass_p (take 2)

2017-12-11 Thread Jakub Jelinek
On Mon, Dec 11, 2017 at 12:09:14PM +0100, Eric Botcazou wrote: > > Is that long enough to be worth it? I mean, in all other places (rtlanal.c, > > recog.c, ...) we use similar code in all spots where it is needed, adding > > an inline would just mean yet another thing to remember. Or do you mean