Re: Fwd: [PATCH] Attribute for unused warning for variables of non-trivial types

2013-07-14 Thread Jason Merrill
On 07/14/2013 01:53 PM, Lubos Lunak wrote: As for the copyright assignment, AFAIK there is a generic SUSE one that should cover this as well. Ah, yes. Jason

Re: Fwd: [PATCH] Attribute for unused warning for variables of non-trivial types

2013-07-14 Thread Lubos Lunak
Sorry, I haven't found time for this until now. On Sunday 14 of July 2013, Jason Merrill wrote: > On 07/08/2013 10:32 AM, Jason Merrill wrote: > > Was it a deliberate decision to put this in the c-common attributes > > rather than the C++-specific ones? I'm not saying it's wrong, just > > inter

Re: Fwd: [PATCH] Attribute for unused warning for variables of non-trivial types

2013-07-13 Thread Jason Merrill
On 07/08/2013 10:32 AM, Jason Merrill wrote: Was it a deliberate decision to put this in the c-common attributes rather than the C++-specific ones? I'm not saying it's wrong, just interested in your thinking. I think it makes sense to leave it in c-common so that types shared between C and C+

Re: Fwd: [PATCH] Attribute for unused warning for variables of non-trivial types

2013-07-08 Thread Jason Merrill
On 06/30/2013 04:21 AM, Lubos Lunak wrote: Are you sure this should be covered by -Wunused-but-set-variable rather than plain -Wunused-variable? While strictly technically speaking the variable is set by the ctor, it's conceptually confusing (is "string s;" really set from the developer's point o

Re: Fwd: [PATCH] Attribute for unused warning for variables of non-trivial types

2013-06-30 Thread Lubos Lunak
Sorry, this has disappeared off my radar for a while. On Wednesday 21 of November 2012, Jason Merrill wrote: > On 11/20/2012 10:39 AM, Lubos Lunak wrote: > >if (TREE_CODE (exp) == VAR_DECL || TREE_CODE (exp) == PARM_DECL) > > -/* Just know that we've seen something for this node. */ > >

Re: [PATCH] Attribute for unused warning for variables of non-trivial types

2012-11-09 Thread Gabriel Dos Reis
On Fri, Nov 9, 2012 at 5:08 AM, Florian Weimer wrote: > On 11/08/2012 08:43 PM, Lubos Lunak wrote: > >> The patch implements an attribute for marking types for which gcc cannot >> on >> its own issue warnings about unused variables (e.g. because the ctor is >> external), but for which such a war

Re: [PATCH] Attribute for unused warning for variables of non-trivial types

2012-11-09 Thread Florian Weimer
On 11/08/2012 08:43 PM, Lubos Lunak wrote: The patch implements an attribute for marking types for which gcc cannot on its own issue warnings about unused variables (e.g. because the ctor is external), but for which such a warning might be useful anyway (e.g. std::string). I'm not sure if th

[PATCH] Attribute for unused warning for variables of non-trivial types

2012-11-08 Thread Lubos Lunak
Hello, could somebody please review http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55203 (patch also attached)? The patch implements an attribute for marking types for which gcc cannot on its own issue warnings about unused variables (e.g. because the ctor is external), but for which such a w