Re: [PATCH] Avoid useless lookup_external_ref calls with LTO

2018-12-15 Thread Jan Hubicka
> > 2018-10-31 Richard Biener > > * dwarf2out.c (build_abbrev_table): Guard lookup_external_ref call > with is_type_die. As discussed on IRC, i have backported this to GCC 8 because it causes noticeable slowness when building Firefox with debug info. Honza

Re: [PATCH] Avoid useless lookup_external_ref calls with LTO

2018-10-31 Thread Jan Hubicka
> > Honza reports high CPU usage from lookup_external_ref at LTRANS time. > This is likely because build_abbrev_table calls it on all DIEs > rather than just type DIEs which we populate the ref table with. > So we end up calling it for all the DIEs refering to early debug, > possibly many

[PATCH] Avoid useless lookup_external_ref calls with LTO

2018-10-31 Thread Richard Biener
Honza reports high CPU usage from lookup_external_ref at LTRANS time. This is likely because build_abbrev_table calls it on all DIEs rather than just type DIEs which we populate the ref table with. So we end up calling it for all the DIEs refering to early debug, possibly many distinct ones with