Re: [PATCH] C/C++: add fix-it hints for missing '&' and '*' (PR c++/87850)

2018-11-13 Thread Jason Merrill
On Mon, Nov 12, 2018 at 4:32 PM Martin Sebor wrote: > On 11/11/2018 02:02 PM, David Malcolm wrote: > > On Sun, 2018-11-11 at 11:01 -0700, Martin Sebor wrote: > >> On 11/10/2018 12:01 AM, Eric Gallager wrote: > >>> On 11/9/18, David Malcolm wrote: > This patch adds a fix-it hint to various

Re: [PATCH] C/C++: add fix-it hints for missing '&' and '*' (PR c++/87850)

2018-11-12 Thread Martin Sebor
On 11/11/2018 02:02 PM, David Malcolm wrote: On Sun, 2018-11-11 at 11:01 -0700, Martin Sebor wrote: On 11/10/2018 12:01 AM, Eric Gallager wrote: On 11/9/18, David Malcolm wrote: This patch adds a fix-it hint to various pointer-vs-non-pointer diagnostics, suggesting the addition of a leading

Re: [PATCH] C/C++: add fix-it hints for missing '&' and '*' (PR c++/87850)

2018-11-11 Thread David Malcolm
On Sun, 2018-11-11 at 11:01 -0700, Martin Sebor wrote: > On 11/10/2018 12:01 AM, Eric Gallager wrote: > > On 11/9/18, David Malcolm wrote: > > > This patch adds a fix-it hint to various pointer-vs-non-pointer > > > diagnostics, suggesting the addition of a leading '&' or '*'. > > > > > > For

Re: [PATCH] C/C++: add fix-it hints for missing '&' and '*' (PR c++/87850)

2018-11-11 Thread Martin Sebor
On 11/10/2018 12:01 AM, Eric Gallager wrote: On 11/9/18, David Malcolm wrote: This patch adds a fix-it hint to various pointer-vs-non-pointer diagnostics, suggesting the addition of a leading '&' or '*'. For example, note the ampersand fix-it hint in the following: demo.c:5:22: error:

Re: [PATCH] C/C++: add fix-it hints for missing '&' and '*' (PR c++/87850)

2018-11-09 Thread Eric Gallager
On 11/9/18, David Malcolm wrote: > This patch adds a fix-it hint to various pointer-vs-non-pointer > diagnostics, suggesting the addition of a leading '&' or '*'. > > For example, note the ampersand fix-it hint in the following: > > demo.c:5:22: error: invalid conversion from 'pthread_key_t' {aka

[PATCH] C/C++: add fix-it hints for missing '&' and '*' (PR c++/87850)

2018-11-09 Thread David Malcolm
This patch adds a fix-it hint to various pointer-vs-non-pointer diagnostics, suggesting the addition of a leading '&' or '*'. For example, note the ampersand fix-it hint in the following: demo.c:5:22: error: invalid conversion from 'pthread_key_t' {aka 'unsigned int'} to 'pthread_key_t*' {aka