[PATCH] Change semantics of -frecord-gcc-switches and add -frecord-gcc-switches-format.

ping Any hope for getting this in? We really need this support. Thanks! > On 3/12/21 6:39 PM, Martin Liška wrote: > PING^2 > > On 3/1/21 1:07 PM, Martin Liška wrote: >> PING >> On 2/18/21 10:18 AM, Martin Liška wrote: >>> On 2/16/21 10:17 PM, Qing Zhao wrote: Hello, What’s

Re: [PATCH] Change semantics of -frecord-gcc-switches and add -frecord-gcc-switches-format.

PING^2 On 3/1/21 1:07 PM, Martin Liška wrote: PING On 2/18/21 10:18 AM, Martin Liška wrote: On 2/16/21 10:17 PM, Qing Zhao wrote: Hello, What’s the status of this patch now? Is there any major technical issue with the patch? Our company has been waiting for this patch for almost one year,

Re: [PATCH] Change semantics of -frecord-gcc-switches and add -frecord-gcc-switches-format.

PING On 2/18/21 10:18 AM, Martin Liška wrote: On 2/16/21 10:17 PM, Qing Zhao wrote: Hello, What’s the status of this patch now? Is there any major technical issue with the patch? Our company has been waiting for this patch for almost one year, we need it for our important application.

Re: [PATCH] Change semantics of -frecord-gcc-switches and add -frecord-gcc-switches-format.

On 2/16/21 10:17 PM, Qing Zhao wrote: Hello, What’s the status of this patch now? Is there any major technical issue with the patch? Our company has been waiting for this patch for almost one year, we need it for our important application. Hello. You are right, we've been waiting for

Re: [PATCH] Change semantics of -frecord-gcc-switches and add -frecord-gcc-switches-format.

Hello, What’s the status of this patch now? Is there any major technical issue with the patch? Our company has been waiting for this patch for almost one year, we need it for our important application. Could this one be approved and committed to gcc11? Thanks. Qing > On Feb 5, 2021, at

[PATCH] Change semantics of -frecord-gcc-switches and add -frecord-gcc-switches-format.

Fri, 5 Feb 2021 10:28:57 +0100 Subject: [PATCH] Change semantics of -frecord-gcc-switches and add -frecord-gcc-switches-format. gcc/ChangeLog: * common.opt: Document new options -frecord-gcc-switches-format and -frecord-gcc-switches-file. * doc/invoke.texi: Document the new options. * dwarf2ou

Re: [stage1][PATCH] Change semantics of -frecord-gcc-switches and add -frecord-gcc-switches-format.

PING^4 On 1/22/21 2:33 PM, Martin Liška wrote: PING^3 On 1/14/21 10:03 AM, Martin Liška wrote: PING^2 On 1/6/21 3:21 PM, Martin Liška wrote: PING On 12/4/20 2:30 PM, Martin Liška wrote: On 12/4/20 10:03 AM, Richard Biener wrote: Otherwise 0001- looks good to me. Pushed that to master.

Re: [stage1][PATCH] Change semantics of -frecord-gcc-switches and add -frecord-gcc-switches-format.

PING^3 On 1/14/21 10:03 AM, Martin Liška wrote: PING^2 On 1/6/21 3:21 PM, Martin Liška wrote: PING On 12/4/20 2:30 PM, Martin Liška wrote: On 12/4/20 10:03 AM, Richard Biener wrote: Otherwise 0001- looks good to me. Pushed that to master. As said I'd like to see opinions from others on

Re: [stage1][PATCH] Change semantics of -frecord-gcc-switches and add -frecord-gcc-switches-format.

On 1/15/21 8:14 PM, Alexandre Oliva wrote: Hello, Martin, Our testing detected unexpected -dumpbase-ext options making to the producer string. I tracked it down to something weird that happened in this patch: On Dec 4, 2020, Martin Liška wrote: +++ b/gcc/dwarf2out.c - case

Re: [stage1][PATCH] Change semantics of -frecord-gcc-switches and add -frecord-gcc-switches-format.

Hello, Martin, Our testing detected unexpected -dumpbase-ext options making to the producer string. I tracked it down to something weird that happened in this patch: On Dec 4, 2020, Martin Liška wrote: > +++ b/gcc/dwarf2out.c > - case OPT_dumpbase: > - case OPT_dumpbase_ext: > -

Re: [stage1][PATCH] Change semantics of -frecord-gcc-switches and add -frecord-gcc-switches-format.

PING^2 On 1/6/21 3:21 PM, Martin Liška wrote: PING On 12/4/20 2:30 PM, Martin Liška wrote: On 12/4/20 10:03 AM, Richard Biener wrote: Otherwise 0001- looks good to me. Pushed that to master. As said I'd like to see opinions from others on the driver / backend communication for 0002. To

Re: [stage1][PATCH] Change semantics of -frecord-gcc-switches and add -frecord-gcc-switches-format.

PING On 12/4/20 2:30 PM, Martin Liška wrote: On 12/4/20 10:03 AM, Richard Biener wrote: Otherwise 0001- looks good to me. Pushed that to master. As said I'd like to see opinions from others on the driver / backend communication for 0002. To be honest, we moved back to the original

Re: [stage1][PATCH] Change semantics of -frecord-gcc-switches and add -frecord-gcc-switches-format.

On Fri, Dec 4, 2020 at 2:35 PM Jakub Jelinek wrote: > > On Fri, Dec 04, 2020 at 02:30:45PM +0100, Martin Liška wrote: > > On 12/4/20 10:03 AM, Richard Biener wrote: > > > Otherwise 0001- looks good to me. > > > > Pushed that to master. > > > > > As said I'd like to see opinions > > > from others

Re: [stage1][PATCH] Change semantics of -frecord-gcc-switches and add -frecord-gcc-switches-format.

On Fri, Dec 04, 2020 at 02:30:45PM +0100, Martin Liška wrote: > On 12/4/20 10:03 AM, Richard Biener wrote: > > Otherwise 0001- looks good to me. > > Pushed that to master. > > > As said I'd like to see opinions > > from others on the > > driver / backend communication for 0002. > > To be

Re: [stage1][PATCH] Change semantics of -frecord-gcc-switches and add -frecord-gcc-switches-format.

On 12/4/20 10:03 AM, Richard Biener wrote: Otherwise 0001- looks good to me. Pushed that to master. As said I'd like to see opinions from others on the driver / backend communication for 0002. To be honest, we moved back to the original implementation which used a temporary file. There

Re: [stage1][PATCH] Change semantics of -frecord-gcc-switches and add -frecord-gcc-switches-format.

On Fri, Dec 4, 2020 at 9:08 AM Martin Liška wrote: > > On 12/3/20 2:12 PM, Richard Biener wrote: > > Can we somehow preserve this by making the helper produce separate > > strings for the 'GNU C17 11.0 ...' part and the options passed part? So the > > -fverbose-asm and -Q consumer can continue

Re: [stage1][PATCH] Change semantics of -frecord-gcc-switches and add -frecord-gcc-switches-format.

On 12/3/20 2:12 PM, Richard Biener wrote: Can we somehow preserve this by making the helper produce separate strings for the 'GNU C17 11.0 ...' part and the options passed part? So the -fverbose-asm and -Q consumer can continue to nicely print the option part? Yep, good idea. I've just done

Re: [stage1][PATCH] Change semantics of -frecord-gcc-switches and add -frecord-gcc-switches-format.

On Thu, Nov 26, 2020 at 2:55 PM Martin Liška wrote: > > On 11/25/20 2:48 PM, Richard Biener wrote: > > On Mon, Nov 23, 2020 at 2:02 PM Martin Liška wrote: > >> > >> On 11/23/20 12:00 PM, Richard Biener wrote: > >>> Can you split out the unifying of -[gf]record-gcc-switches processing > >>> and

Re: [stage1][PATCH] Change semantics of -frecord-gcc-switches and add -frecord-gcc-switches-format.

^PING On 11/26/20 2:55 PM, Martin Liška wrote: On 11/25/20 2:48 PM, Richard Biener wrote: On Mon, Nov 23, 2020 at 2:02 PM Martin Liška wrote: On 11/23/20 12:00 PM, Richard Biener wrote: Can you split out the unifying of -[gf]record-gcc-switches processing and the target hook adjustment

Re: [stage1][PATCH] Change semantics of -frecord-gcc-switches and add -frecord-gcc-switches-format.

On 11/25/20 2:48 PM, Richard Biener wrote: On Mon, Nov 23, 2020 at 2:02 PM Martin Liška wrote: On 11/23/20 12:00 PM, Richard Biener wrote: Can you split out the unifying of -[gf]record-gcc-switches processing and the target hook adjustment from the change introducing

Re: [stage1][PATCH] Change semantics of -frecord-gcc-switches and add -frecord-gcc-switches-format.

On Mon, Nov 23, 2020 at 2:02 PM Martin Liška wrote: > > On 11/23/20 12:00 PM, Richard Biener wrote: > > Can you split out the unifying of -[gf]record-gcc-switches processing > > and the target hook adjustment from the change introducing > > -frecord-gcc-switches-format? > > Sure. > > > > >

Re: [stage1][PATCH] Change semantics of -frecord-gcc-switches and add -frecord-gcc-switches-format.

rom b6c135ff7709df10e8bc3d6fab9d7987ed263fa2 Mon Sep 17 00:00:00 2001 From: Martin Liska Date: Mon, 23 Nov 2020 14:10:38 +0100 Subject: [PATCH] Change semantics of -frecord-gcc-switches and add -frecord-gcc-switches-format. gcc/ChangeLog: * common.opt: Document new options -frecord-gcc-switc

Re: [stage1][PATCH] Change semantics of -frecord-gcc-switches and add -frecord-gcc-switches-format.

On 11/23/20 12:00 PM, Richard Biener wrote: Can you split out the unifying of -[gf]record-gcc-switches processing and the target hook adjustment from the change introducing -frecord-gcc-switches-format? Sure. dwarf2out.c seems to retain its gen_producer_string () even though you duplicate

Re: [stage1][PATCH] Change semantics of -frecord-gcc-switches and add -frecord-gcc-switches-format.

On Mon, Nov 23, 2020 at 10:00 AM Martin Liška wrote: > > On 11/20/20 10:49 AM, Richard Biener wrote: > > On Fri, Apr 3, 2020 at 8:15 PM Egeyar Bagcioglu > > wrote: > >> > >> > >> > >> On 3/18/20 10:05 AM, Martin Liška wrote: > >>> On 3/17/20 7:43 PM, Egeyar Bagcioglu wrote: > Hi Martin, >

Re: [stage1][PATCH] Change semantics of -frecord-gcc-switches and add -frecord-gcc-switches-format.

Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed in next stage1? Thanks, Martin >From b0e9bd2a625d06417fb2b52d04a824f33aba633c Mon Sep 17 00:00:00 2001 From: Martin Liska Date: Thu, 5 Mar 2020 09:39:17 +0100 Subject: [PATCH] Change semantics o

Re: [stage1][PATCH] Change semantics of -frecord-gcc-switches and add -frecord-gcc-switches-format.

On Fri, Apr 3, 2020 at 8:15 PM Egeyar Bagcioglu wrote: > > > > On 3/18/20 10:05 AM, Martin Liška wrote: > > On 3/17/20 7:43 PM, Egeyar Bagcioglu wrote: > >> Hi Martin, > >> > >> I like the patch. It definitely serves our purposes at Oracle and > >> provides another way to do what my previous

Re: [stage1][PATCH] Change semantics of -frecord-gcc-switches and add -frecord-gcc-switches-format.

> On Nov 16, 2020, at 4:29 AM, Martin Liška wrote: > > On 11/10/20 9:53 PM, Qing Zhao wrote: >> The deadline for gcc11 stage 1 is approaching. The pinged patch is one that >> has been sent for review 8 months ago in order to >> Make into gcc11. > > Hello. > > You didn't miss the deadline

Re: [stage1][PATCH] Change semantics of -frecord-gcc-switches and add -frecord-gcc-switches-format.

On 11/10/20 9:53 PM, Qing Zhao wrote: The deadline for gcc11 stage 1 is approaching.  The pinged patch is one that has been sent for review 8 months ago in order to Make into gcc11. Hello. You didn't miss the deadline as all patches sent before stage1 can be reviewed even during stage3.

Re: [stage1][PATCH] Change semantics of -frecord-gcc-switches and add -frecord-gcc-switches-format.

> PING^7 on the following patch proposed 8 months ago for gcc11: > > https://gcc.gnu.org/pipermail/gcc-patches/2020-March/542198.html > > > The deadline for gcc11 stage 1 is approaching. The pinged patch is > one that has been

Re: [stage1][PATCH] Change semantics of -frecord-gcc-switches and add -frecord-gcc-switches-format.

Jakub and Jeff, PING^7 on the following patch proposed 8 months ago for gcc11: https://gcc.gnu.org/pipermail/gcc-patches/2020-March/542198.html The deadline for gcc11 stage 1 is approaching. The pinged patch is one that has

Re: [stage1][PATCH] Change semantics of -frecord-gcc-switches and add -frecord-gcc-switches-format.

PING^6 The patch is in review process for more than 6 months, can please any global reviewer take a look at it? Thanks, Martin On 9/25/20 4:55 PM, Martin Liška wrote: PING^5

Re: [stage1][PATCH] Change semantics of -frecord-gcc-switches and add -frecord-gcc-switches-format.

> On Sep 25, 2020, at 9:55 AM, Martin Liška wrote: > > PING^5 > Thanks a lot for ping this patch again. Hopefully it can be committed into GCC 11 very soon. Qing > On 7/21/20 6:24 PM, Qing Zhao wrote: >> PING^4. >> Our company is waiting for this patch to be committed to upstream. >>

Re: [stage1][PATCH] Change semantics of -frecord-gcc-switches and add -frecord-gcc-switches-format.

PING^5 On 7/21/20 6:24 PM, Qing Zhao wrote: PING^4. Our company is waiting for this patch to be committed to upstream. Thanks a lot. Qing On Jun 16, 2020, at 7:49 AM, Martin Liška wrote: PING^3 On 6/2/20 11:16 AM, Martin Liška wrote: PING^2 On 5/15/20 11:58 AM, Martin Liška wrote:

Re: [stage1][PATCH] Change semantics of -frecord-gcc-switches and add -frecord-gcc-switches-format.

On 7/23/20 5:01 PM, Qing Zhao wrote: Hi, Thanks a lot for the info. On Jul 23, 2020, at 5:07 AM, Martin Liška wrote: On 7/21/20 6:24 PM, Qing Zhao wrote: 4. Our company is waiting for this patch to be committed to upstream. Hello. Please note that patch review can sometimes take some

Re: [stage1][PATCH] Change semantics of -frecord-gcc-switches and add -frecord-gcc-switches-format.

Hi, Thanks a lot for the info. > On Jul 23, 2020, at 5:07 AM, Martin Liška wrote: > > On 7/21/20 6:24 PM, Qing Zhao wrote: >> 4. >> Our company is waiting for this patch to be committed to upstream. > > Hello. > > Please note that patch review can sometimes take some time. Yes, I

Re: [stage1][PATCH] Change semantics of -frecord-gcc-switches and add -frecord-gcc-switches-format.

On 7/21/20 6:24 PM, Qing Zhao wrote: 4. Our company is waiting for this patch to be committed to upstream. Hello. Please note that patch review can sometimes take some time. You can still install the patch to your local branch and note that the next major release will be released in about 9

Re: [stage1][PATCH] Change semantics of -frecord-gcc-switches and add -frecord-gcc-switches-format.

PING^4. Our company is waiting for this patch to be committed to upstream. Thanks a lot. Qing > On Jun 16, 2020, at 7:49 AM, Martin Liška wrote: > > PING^3 > > On 6/2/20 11:16 AM, Martin Liška wrote: >> PING^2 >> On 5/15/20 11:58 AM, Martin Liška wrote: >>> We're in stage1: PING^1 >>> >>>

Re: [stage1][PATCH] Change semantics of -frecord-gcc-switches and add -frecord-gcc-switches-format.

PING^3 On 6/2/20 11:16 AM, Martin Liška wrote: PING^2 On 5/15/20 11:58 AM, Martin Liška wrote: We're in stage1: PING^1 On 4/3/20 8:15 PM, Egeyar Bagcioglu wrote: On 3/18/20 10:05 AM, Martin Liška wrote: On 3/17/20 7:43 PM, Egeyar Bagcioglu wrote: Hi Martin, I like the patch. It

Re: [stage1][PATCH] Change semantics of -frecord-gcc-switches and add -frecord-gcc-switches-format.

PING^2 On 5/15/20 11:58 AM, Martin Liška wrote: We're in stage1: PING^1 On 4/3/20 8:15 PM, Egeyar Bagcioglu wrote: On 3/18/20 10:05 AM, Martin Liška wrote: On 3/17/20 7:43 PM, Egeyar Bagcioglu wrote: Hi Martin, I like the patch. It definitely serves our purposes at Oracle and provides

Re: [stage1][PATCH] Change semantics of -frecord-gcc-switches and add -frecord-gcc-switches-format.

We're in stage1: PING^1 On 4/3/20 8:15 PM, Egeyar Bagcioglu wrote: On 3/18/20 10:05 AM, Martin Liška wrote: On 3/17/20 7:43 PM, Egeyar Bagcioglu wrote: Hi Martin, I like the patch. It definitely serves our purposes at Oracle and provides another way to do what my previous patches did as

Re: [stage1][PATCH] Change semantics of -frecord-gcc-switches and add -frecord-gcc-switches-format.

On 4/3/20 8:15 PM, Egeyar Bagcioglu wrote: Hi Martin, Hello. I noticed that some comments in the patch were still referring to --record-gcc-command-line, the option I suggested earlier. I updated those comments to mention -frecord-gcc-switches-format instead and also added my name to the

Re: [stage1][PATCH] Change semantics of -frecord-gcc-switches and add -frecord-gcc-switches-format.

:00:00 2001 From: Martin Liska Date: Thu, 5 Mar 2020 09:39:17 +0100 Subject: [PATCH] Change semantics of -frecord-gcc-switches and add -frecord-gcc-switches-format. gcc/ChangeLog: 2020-03-17 Martin Liska Egeyar Bagcioglu * common.opt: Add new option -frecord-gcc-switches-for

Re: [stage1][PATCH] Change semantics of -frecord-gcc-switches and add -frecord-gcc-switches-format.

in next stage1? Thanks, Martin >From 60653c2c37d8c2f0eec171c3ab9a1b7487b82e0f Mon Sep 17 00:00:00 2001 From: Martin Liska Date: Thu, 5 Mar 2020 09:39:17 +0100 Subject: [PATCH] Change semantics of -frecord-gcc-switches and add -frecord-gcc-switches-format. gcc/ChangeLog: 2020-03-17 Mar

Re: [stage1][PATCH] Change semantics of -frecord-gcc-switches and add -frecord-gcc-switches-format.

Hi Martin, I like the patch. It definitely serves our purposes at Oracle and provides another way to do what my previous patches did as well. 1) It keeps the backwards compatibility regarding -frecord-gcc-switches; therefore, removes my related doubts about your previous patch. 2) It still

[stage1][PATCH] Change semantics of -frecord-gcc-switches and add -frecord-gcc-switches-format.

ect: [PATCH] Change semantics of -frecord-gcc-switches and add -frecord-gcc-switches-format. gcc/ChangeLog: 2020-03-17 Martin Liska * common.opt: Add new option -frecord-gcc-switches-format. * doc/invoke.texi: Document the new option. * doc/tm.texi: Remove print_switch_type documentation en