Re: [PATCH] Convert ipcp_vr_lattice to type agnostic framework.

2023-06-10 Thread Aldy Hernandez via Gcc-patches
orth. I see, thanks. [...] How's this? One minor observation below... Aldy From 2fd0ae47aa094675a02763e72d7bb7404ed9334b Mon Sep 17 00:00:00 2001 From: Aldy Hernandez Date: Wed, 17 May 2023 11:29:34 +0200 Subject: [PATCH] Convert ipcp_vr_lattice to type agnostic framework. This converts th

Re: [PATCH] Convert ipcp_vr_lattice to type agnostic framework.

2023-06-10 Thread Martin Jambor
and PARM_TYPE of the parameter. */ >>>> >>>> -value_range >>>> -ipa_value_range_from_jfunc (ipa_node_params *info, cgraph_edge *cs, >>>> +void >>>> +ipa_value_range_from_jfunc (vrange , >>>> + i

Re: [PATCH] Convert ipcp_vr_lattice to type agnostic framework.

2023-06-07 Thread Aldy Hernandez via Gcc-patches
for (int i = 0; i < count; ++i) new (>m_known_value_ranges[i]) - value_range (); + Value_Range (); } avals->m_known_value_ranges[i] = vr;

Re: [PATCH] Convert ipcp_vr_lattice to type agnostic framework.

2023-06-06 Thread Aldy Hernandez via Gcc-patches
My apologies for the delay. I was on vacation. On 5/26/23 18:17, Martin Jambor wrote: Hello, On Mon, May 22 2023, Aldy Hernandez wrote: I've adjusted the patch with some minor cleanups that came up when I implemented the rest of the IPA revamp. Rested. OK? On Wed, May 17, 2023 at 4:31 PM

Re: [PATCH] Convert ipcp_vr_lattice to type agnostic framework.

2023-05-26 Thread Martin Jambor
Hello, On Mon, May 22 2023, Aldy Hernandez wrote: > I've adjusted the patch with some minor cleanups that came up when I > implemented the rest of the IPA revamp. > > Rested. OK? > > On Wed, May 17, 2023 at 4:31 PM Aldy Hernandez wrote: >> >> This converts the lattice to store ranges in

Re: [PATCH] Convert ipcp_vr_lattice to type agnostic framework.

2023-05-22 Thread Aldy Hernandez via Gcc-patches
e_range tmp; > + Value_Range tmp (type); > vr[i].get_vrange (tmp, type); > > if (!tmp.undefined_p () && !tmp.varying_p ()) > diff --git a/gcc/ipa-prop.h b/gcc/ipa-prop.h > index 3b580ebb903..3921e33940d 100644 > --- a/gcc/ipa-prop.h >

Re: [PATCH] Convert ipcp_vr_lattice to type agnostic framework.

2023-05-17 Thread Aldy Hernandez via Gcc-patches
On 5/17/23 16:30, Aldy Hernandez wrote: This converts the lattice to store ranges in Value_Range instead of value_range (*) to make it type agnostic, and adjust all users accordingly. I think it is a good example on converting from static ranges to more general, type agnostic ones. I've

[PATCH] Convert ipcp_vr_lattice to type agnostic framework.

2023-05-17 Thread Aldy Hernandez via Gcc-patches
This converts the lattice to store ranges in Value_Range instead of value_range (*) to make it type agnostic, and adjust all users accordingly. I think it is a good example on converting from static ranges to more general, type agnostic ones. I've been careful to make sure Value_Range never ends