Re: [PING*2][PATCH] DWARF: add abstract origin links on lexical blocks DIEs

2016-05-10 Thread Pierre-Marie de Rodat
On 05/09/2016 01:01 PM, Richard Biener wrote: Ok and sorry for the delay. No problem. :-) Thanks, this is committed! -- Pierre-Marie de Rodat

Re: [PING*2][PATCH] DWARF: add abstract origin links on lexical blocks DIEs

2016-05-09 Thread Richard Biener
On Wed, May 4, 2016 at 4:23 PM, Pierre-Marie de Rodat wrote: > Ping for the patch submitted at > . It applies just > fine on the current trunk and still bootstrapps and regtests successfuly on > x86_64-linux. > > Thank you in advance, Ok a

[PING*2][PATCH] DWARF: add abstract origin links on lexical blocks DIEs

2016-05-04 Thread Pierre-Marie de Rodat
Ping for the patch submitted at . It applies just fine on the current trunk and still bootstrapps and regtests successfuly on x86_64-linux. Thank you in advance, -- Pierre-Marie de Rodat

[PING][PATCH] DWARF: add abstract origin links on lexical blocks DIEs

2016-04-26 Thread Pierre-Marie de Rodat
Ping for the patch submitted at . It applies just fine on the current trunk and still bootstrapps and regtests successfuly on x86_64-linux. Thank you in advance, -- Pierre-Marie de Rodat

Re: [PATCH] DWARF: add abstract origin links on lexical blocks DIEs

2016-01-20 Thread Pierre-Marie de Rodat
de Rodat >From 451d62ff871734727b0f0f570f89b6cfbed922f2 Mon Sep 17 00:00:00 2001 From: Pierre-Marie de Rodat Date: Tue, 12 Jan 2016 14:50:33 +0100 Subject: [PATCH] DWARF: add abstract origin links on lexical blocks DIEs Track from which abstract lexical block concrete ones come from in DWARF

Re: [PATCH] DWARF: add abstract origin links on lexical blocks DIEs

2016-01-18 Thread Pierre-Marie de Rodat
On 01/18/2016 10:45 AM, Eric Botcazou wrote: which means take the other option of writing a scan-assembler testcase looking for the previously missing DWARF. Fine with me (either Ada or C as far as I'm concerned). Thank you for your inputs! I’m going to try that, then. I hope this test will

Re: [PATCH] DWARF: add abstract origin links on lexical blocks DIEs

2016-01-18 Thread Eric Botcazou
> But that tests GDB and not GCCs generation of DWARF ... But GDB only consumes the DWARF generated by GCC, it cannot synthetize it. ;-) > which means take the other option of writing a scan-assembler testcase > looking for the previously missing DWARF. Fine with me (either Ada or C as far as I'

Re: [PATCH] DWARF: add abstract origin links on lexical blocks DIEs

2016-01-18 Thread Richard Biener
On Sun, Jan 17, 2016 at 9:09 PM, Eric Botcazou wrote: >> Sounds like a good excuse to add a guality for Ada (which has unique >> needs for dwarf). > > Well, the guality testsuite is a pain to maintain so I'd rather not. > The GDB testsuite is clearly the right place for this kind of testcases. Bu

Re: [PATCH] DWARF: add abstract origin links on lexical blocks DIEs

2016-01-17 Thread Eric Botcazou
> Sounds like a good excuse to add a guality for Ada (which has unique > needs for dwarf). Well, the guality testsuite is a pain to maintain so I'd rather not. The GDB testsuite is clearly the right place for this kind of testcases. -- Eric Botcazou

Re: [PATCH] DWARF: add abstract origin links on lexical blocks DIEs

2016-01-15 Thread Richard Biener
On Fri, Jan 15, 2016 at 3:41 PM, Pierre-Marie de Rodat On 01/13/2016 01:17 PM, Richard Biener wrote: >> >> I wonder if you can construct a guality testcase that passes with and >> fails without >> the patch? > > > I’ve tried to first look at how guality testcases are written (thanks for > your ans

Re: [PATCH] DWARF: add abstract origin links on lexical blocks DIEs

2016-01-15 Thread Pierre-Marie de Rodat
On 01/13/2016 01:17 PM, Richard Biener wrote: I wonder if you can construct a guality testcase that passes with and fails without the patch? I’ve tried to first look at how guality testcases are written (thanks for your answers on IRC, by the way :-)) and then how I could write a testcase for

Re: [PATCH] DWARF: add abstract origin links on lexical blocks DIEs

2016-01-13 Thread Richard Biener
On Tue, Jan 12, 2016 at 6:05 PM, Pierre-Marie de Rodat wrote: > Hello, > > Although the following patch does not fix a regression, I believe it fixes a > bug visible from a debugger, so I think it’s a valid candidate at this > stage. > > This change tracks from which abstract lexical block concret

[PATCH] DWARF: add abstract origin links on lexical blocks DIEs

2016-01-12 Thread Pierre-Marie de Rodat
Hello, Although the following patch does not fix a regression, I believe it fixes a bug visible from a debugger, so I think it’s a valid candidate at this stage. This change tracks from which abstract lexical block concrete ones come from in DWARF so that debuggers can inherit the former fro