Re: [PATCH] Fix -imacros (PR c/57653)

2014-07-25 Thread Jeff Law
On 07/23/14 11:49, Marek Polacek wrote: On Thu, Jul 17, 2014 at 02:40:27AM -0600, Jeff Law wrote: I was really hoping someone could add tests from the old (2004?) thread between DJ and Per to ensure we weren't regressing any of those cases while fixing 57653. In fact, I think I'd pre-approved w

Re: [PATCH] Fix -imacros (PR c/57653)

2014-07-23 Thread Marek Polacek
On Thu, Jul 17, 2014 at 02:40:27AM -0600, Jeff Law wrote: > I was really hoping someone could add tests from the old (2004?) thread > between DJ and Per to ensure we weren't regressing any of those cases while > fixing 57653. In fact, I think I'd pre-approved with those tests added ;-) All I coul

Re: [PATCH] Fix -imacros (PR c/57653)

2014-07-17 Thread Jeff Law
On 07/15/14 02:18, Marek Polacek wrote: This is a revised patch that Peter recently submitted , but it was lacking a testcase and a better comment. This patch adds a testcase (kind of a hacky one), the comment is hopefully better too. Jo

[PATCH] Fix -imacros (PR c/57653)

2014-07-15 Thread Marek Polacek
This is a revised patch that Peter recently submitted , but it was lacking a testcase and a better comment. This patch adds a testcase (kind of a hacky one), the comment is hopefully better too. Joseph already said that the code changes lo