Re: [PATCH] Fix RTL fwprop compile-time for PR56113

2013-01-30 Thread Michael Matz
Hi, On Wed, 30 Jan 2013, Richard Biener wrote: > 483 { > 484 redirect_immediate_dominators (CDI_DOMINATORS, bb, new_bb); > 485 set_immediate_dominator (CDI_DOMINATORS, new_bb, bb); > 486 } > > but that doesn't set dominance info to DOM_OK again. The > iterate

Re: [PATCH] Fix RTL fwprop compile-time for PR56113

2013-01-30 Thread Richard Biener
On Wed, 30 Jan 2013, Steven Bosscher wrote: > On Wed, Jan 30, 2013 at 12:01 AM, Steven Bosscher wrote: > > To prevent that mistake in the future, I've add an assert in dominance.c. > > Hmm, that worked with my release-checking compiler of course, but > fails in at least tree-ssa-dom.c (same as fo

Re: [PATCH] Fix RTL fwprop compile-time for PR56113

2013-01-29 Thread Steven Bosscher
On Wed, Jan 30, 2013 at 12:01 AM, Steven Bosscher wrote: > To prevent that mistake in the future, I've add an assert in dominance.c. Hmm, that worked with my release-checking compiler of course, but fails in at least tree-ssa-dom.c (same as for fwprop.c, loop_optimizer_init destroys fast queries)

[PATCH] Fix RTL fwprop compile-time for PR56113

2013-01-29 Thread Steven Bosscher
Hello, This brings down compile time for fwprop by avoiding CFG changes in loop_optimizer_init(). The CFG changes it could make would invalidate the fast dominance queries, so that walk_dominator_tree had to work with the slow queries -- rather painful on a CFG with an almost flat dominator tree.