Re: [PATCH] Fix a missed case in predicate analysis of the late uninit pass

2019-04-29 Thread Jeff Law
On 4/8/19 3:00 AM, Richard Biener wrote: > On Fri, Apr 5, 2019 at 2:26 PM Vladislav Ivanishin wrote: >> >> Richard Biener writes: >> >>> On Thu, Apr 4, 2019 at 4:05 PM Vladislav Ivanishin wrote: Richard Biener writes: > On Mon, Apr 1, 2019 at 5:36 PM Vladislav Ivanishin

Re: [PATCH] Fix a missed case in predicate analysis of the late uninit pass

2019-04-08 Thread Richard Biener
On Fri, Apr 5, 2019 at 2:26 PM Vladislav Ivanishin wrote: > > Richard Biener writes: > > > On Thu, Apr 4, 2019 at 4:05 PM Vladislav Ivanishin wrote: > >> > >> Richard Biener writes: > >> > >> > On Mon, Apr 1, 2019 at 5:36 PM Vladislav Ivanishin > >> > wrote: > >> >> > >> >> Hi! > >> >> > >>

Re: [PATCH] Fix a missed case in predicate analysis of the late uninit pass

2019-04-05 Thread Vladislav Ivanishin
Richard Biener writes: > On Thu, Apr 4, 2019 at 4:05 PM Vladislav Ivanishin wrote: >> >> Richard Biener writes: >> >> > On Mon, Apr 1, 2019 at 5:36 PM Vladislav Ivanishin wrote: >> >> >> >> Hi! >> >> >> >> This is a fairly trivial change fixing a false negative in >> >> -Wmaybe-uninitialized.

Re: [PATCH] Fix a missed case in predicate analysis of the late uninit pass

2019-04-05 Thread Richard Biener
On Thu, Apr 4, 2019 at 4:05 PM Vladislav Ivanishin wrote: > > Richard Biener writes: > > > On Mon, Apr 1, 2019 at 5:36 PM Vladislav Ivanishin wrote: > >> > >> Hi! > >> > >> This is a fairly trivial change fixing a false negative in > >> -Wmaybe-uninitialized. I am pretty sure this is simply an

Re: [PATCH] Fix a missed case in predicate analysis of the late uninit pass

2019-04-04 Thread Vladislav Ivanishin
Richard Biener writes: > On Mon, Apr 1, 2019 at 5:36 PM Vladislav Ivanishin wrote: >> >> Hi! >> >> This is a fairly trivial change fixing a false negative in >> -Wmaybe-uninitialized. I am pretty sure this is simply an overlooked >> case (is_value_included_in() is not meant to deal with the

Re: [PATCH] Fix a missed case in predicate analysis of the late uninit pass

2019-04-03 Thread Richard Biener
On Mon, Apr 1, 2019 at 5:36 PM Vladislav Ivanishin wrote: > > Hi! > > This is a fairly trivial change fixing a false negative in > -Wmaybe-uninitialized. I am pretty sure this is simply an overlooked > case (is_value_included_in() is not meant to deal with the case where > both compare codes are

[PATCH] Fix a missed case in predicate analysis of the late uninit pass

2019-04-01 Thread Vladislav Ivanishin
Hi! This is a fairly trivial change fixing a false negative in -Wmaybe-uninitialized. I am pretty sure this is simply an overlooked case (is_value_included_in() is not meant to deal with the case where both compare codes are NE_EXPRs, neither does it need to, since their handling is trivial).