On Tue, Feb 5, 2019 at 10:46 AM Nikhil Benesch wrote:
>
> Ian—is there anything preventing this from getting merged? (I don't have
> write access.)
Thanks, committed now.
Ian
> On Thu, Jan 24, 2019 at 11:31 AM Nikhil Benesch
> wrote:
>
> > On Thu, Jan 24, 2019 at 10:15 AM Richard Biener
> >
Ian—is there anything preventing this from getting merged? (I don't have
write access.)
On Thu, Jan 24, 2019 at 11:31 AM Nikhil Benesch
wrote:
> On Thu, Jan 24, 2019 at 10:15 AM Richard Biener
> wrote:
> >
> > Ah, I missed that pt is probably a pointer type as well, then the code
> > simply
On Thu, Jan 24, 2019 at 10:15 AM Richard Biener
wrote:
>
> Ah, I missed that pt is probably a pointer type as well, then the code
> simply aligns the pointed-to type (note dependent on how pt was built
> this seems prone to wreck the TYPE_POINTER_TO/TYPE_NEXT_PTR_TO
> chains which link pointer
On Thu, Jan 24, 2019 at 3:59 PM Nikhil Benesch wrote:
>
> On Thu, Jan 24, 2019 at 6:01 AM Richard Biener
> wrote:
> >
> > On Thu, Jan 24, 2019 at 2:18 AM Nikhil Benesch
> > wrote:
> > >
> > > diff --git a/gcc/go/go-gcc.cc b/gcc/go/go-gcc.cc
> > > index 7fbdd074119..4e9e0e3026a 100644
> > > ---
On Thu, Jan 24, 2019 at 6:01 AM Richard Biener
wrote:
>
> On Thu, Jan 24, 2019 at 2:18 AM Nikhil Benesch
> wrote:
> >
> > diff --git a/gcc/go/go-gcc.cc b/gcc/go/go-gcc.cc
> > index 7fbdd074119..4e9e0e3026a 100644
> > --- a/gcc/go/go-gcc.cc
> > +++ b/gcc/go/go-gcc.cc
> > @@ -1049,6 +1049,7 @@
On Thu, Jan 24, 2019 at 2:18 AM Nikhil Benesch wrote:
>
> This patch fixes an ICE I reported earlier today as PR go/89019, which
> occurs when compiling sufficiently complicated Go code with link-time
> optimization (i.e., -flto) enabled.
>
> Both of these simple test programs are sufficient to
On Wed, Jan 23, 2019 at 5:18 PM Nikhil Benesch wrote:
>
> 2018-01-23 Nikhil Benesch
>
> PR go/89019
> * go-gcc.cc (Gcc_backend::placeholder_struct_type): Mark
> placeholder structs as requiring structural equality.
> (Gcc_backend::set_placeholder_pointer_type):
This patch fixes an ICE I reported earlier today as PR go/89019, which
occurs when compiling sufficiently complicated Go code with link-time
optimization (i.e., -flto) enabled.
Both of these simple test programs are sufficient to trigger the ICE:
$ cat crash1.go
package main
type
