Re: [PINGv3][PATCH] Fix for PR 61561

2014-08-07 Thread Marat Zakirov
Sendinggcc/ChangeLog Sendinggcc/config/arm/thumb1.md Transmitting file data .. Committed revision 213710. P.S. Sorry for inconvenience. On 08/07/2014 01:02 PM, Marat Zakirov wrote: Sorry ;( Will test&fix it. On 08/07/2014 12:50 PM, Richard Earnshaw wrote: On 08/06/2014 06:44 P

Re: [PINGv3][PATCH] Fix for PR 61561

2014-08-07 Thread Marat Zakirov
Sorry ;( Will test&fix it. On 08/07/2014 12:50 PM, Richard Earnshaw wrote: On 08/06/2014 06:44 PM, Richard Earnshaw wrote: Similarly for the movqi pattern. You haven't updated the thumb1 QImode pattern in the same way. R. On 07/08/14 09:10, Marat Zakirov wrote: --Marat On 08/07/2014 12:00

Re: [PINGv3][PATCH] Fix for PR 61561

2014-08-07 Thread Richard Earnshaw
>>> On 08/06/2014 06:44 PM, Richard Earnshaw wrote: Similarly for the movqi pattern. You haven't updated the thumb1 QImode pattern in the same way. R. On 07/08/14 09:10, Marat Zakirov wrote: > --Marat > On 08/07/2014 12:00 PM, Ramana Radhakrishnan wrote: >> On Thu, Aug 7, 2014 at 8:36 AM,

Re: [PINGv3][PATCH] Fix for PR 61561

2014-08-07 Thread Marat Zakirov
--Marat On 08/07/2014 12:00 PM, Ramana Radhakrishnan wrote: On Thu, Aug 7, 2014 at 8:36 AM, Marat Zakirov wrote: Thank you. $ svn commit Sendinggcc/ChangeLog Sendinggcc/config/arm/thumb1.md Sendinggcc/config/arm/thumb2.md Transmitting file data ... Committed revision 21

Re: [PINGv3][PATCH] Fix for PR 61561

2014-08-07 Thread Ramana Radhakrishnan
On Thu, Aug 7, 2014 at 8:36 AM, Marat Zakirov wrote: > Thank you. > > $ svn commit > Sendinggcc/ChangeLog > Sendinggcc/config/arm/thumb1.md > Sendinggcc/config/arm/thumb2.md > Transmitting file data ... > Committed revision 213695. > > P.S. > > Minor nit was reg. tested. A

Re: [PINGv3][PATCH] Fix for PR 61561

2014-08-07 Thread Marat Zakirov
Thank you. $ svn commit Sendinggcc/ChangeLog Sendinggcc/config/arm/thumb1.md Sendinggcc/config/arm/thumb2.md Transmitting file data ... Committed revision 213695. P.S. Minor nit was reg. tested. On 08/06/2014 06:44 PM, Richard Earnshaw wrote: On 06/08/14 15:14, Ramana

Re: [PINGv3][PATCH] Fix for PR 61561

2014-08-06 Thread Richard Earnshaw
On 06/08/14 15:14, Ramana Radhakrishnan wrote: > > > This is OK thanks. > > > Ramana > Hmm, minor nit. (define_insn "*thumb1_movhi_insn" [(set (match_operand:HI 0 "nonimmediate_operand" "=l,l,m,*r,*h,l") - (match_operand:HI 1 "general_operand" "l,m,l,*h,*r,I"))] + (mat

Re: [PINGv3][PATCH] Fix for PR 61561

2014-08-06 Thread Ramana Radhakrishnan
This is OK thanks. Ramana

[PINGv3][PATCH] Fix for PR 61561

2014-08-06 Thread Marat Zakirov
On 07/30/2014 04:56 PM, Marat Zakirov wrote: On 07/23/2014 05:33 PM, Marat Zakirov wrote: Hi all! This is a friendly reminder message. On 07/17/2014 03:22 PM, Marat Zakirov wrote: On 07/16/2014 01:32 PM, Kyrill Tkachov wrote: On 16/07/14 10:22, Marat Zakirov wrote: Christophe, Please loo

[PINGv2][PATCH] Fix for PR 61561

2014-07-30 Thread Marat Zakirov
On 07/23/2014 05:33 PM, Marat Zakirov wrote: Hi all! This is a friendly reminder message. On 07/17/2014 03:22 PM, Marat Zakirov wrote: On 07/16/2014 01:32 PM, Kyrill Tkachov wrote: On 16/07/14 10:22, Marat Zakirov wrote: Christophe, Please look at a new patch. Draft tests are OK. I'll as

[PING][PATCH] Fix for PR 61561

2014-07-23 Thread Marat Zakirov
Hi all! This is a friendly reminder message. On 07/17/2014 03:22 PM, Marat Zakirov wrote: On 07/16/2014 01:32 PM, Kyrill Tkachov wrote: On 16/07/14 10:22, Marat Zakirov wrote: Christophe, Please look at a new patch. Draft tests are OK. I'll ask your commit approval when full regression (A

Re: [PING][PATCH] Fix for PR 61561

2014-07-17 Thread Marat Zakirov
On 07/16/2014 01:32 PM, Kyrill Tkachov wrote: On 16/07/14 10:22, Marat Zakirov wrote: Christophe, Please look at a new patch. Draft tests are OK. I'll ask your commit approval when full regression (ARM/thumb1/thumb2) tests are done. Hi Marat, I was about to propose the thumb2.md hunk mysel

Re: [PING][PATCH] Fix for PR 61561

2014-07-16 Thread Kyrill Tkachov
Thank to you all. Committed revision 212450. --Marat Original Message Subject:Re: [PING][PATCH] Fix for PR 61561 Date: Thu, 10 Jul 2014 14:01:24 +0100 From: Ramana Radhakrishnan To: Marat Zakirov , "gcc-patches@gcc.gnu.org" CC: Richard Earns

Re: [PING][PATCH] Fix for PR 61561

2014-07-16 Thread Marat Zakirov
gured --with-thumb or when forcing -mthumb. Christophe. On 11 July 2014 11:08, Marat Zakirov wrote: Thank to you all. Committed revision 212450. --Marat Original Message Subject:Re: [PING][PATCH] Fix for PR 61561 Date: Thu, 10 Jul 2014 14:01:24 +0100 From: R

Re: [PING][PATCH] Fix for PR 61561

2014-07-14 Thread Christophe Lyon
t; Thank to you all. >>> >>> Committed revision 212450. >>> >>> --Marat >>> >>> >>> Original Message >>> Subject:Re: [PING][PATCH] Fix for PR 61561 >>> Date: Thu, 10 Jul 2014 14:01:24 +

Re: [PING][PATCH] Fix for PR 61561

2014-07-14 Thread Marat Zakirov
-with-thumb or when forcing -mthumb. Christophe. On 11 July 2014 11:08, Marat Zakirov wrote: Thank to you all. Committed revision 212450. --Marat Original Message Subject:Re: [PING][PATCH] Fix for PR 61561 Date: Thu, 10 Jul 2014 14:01:24 +0100 From: R

Re: Re: [PING][PATCH] Fix for PR 61561

2014-07-11 Thread Christophe Lyon
ct: Re: [PING][PATCH] Fix for PR 61561 > Date: Thu, 10 Jul 2014 14:01:24 +0100 > From: Ramana Radhakrishnan > To: Marat Zakirov , "gcc-patches@gcc.gnu.org" > > CC: Richard Earnshaw , Kyrylo Tkachov > , Slava Garbuzov , Yuri > Gribov , "mara...

Re: [PATCH] Fix for PR 61561

2014-07-11 Thread Richard Earnshaw
On 19/06/14 21:19, Yuri Gribov wrote: >> Thirdly, we also need to fix movhi_bytes (for pre-v4) thumb2_movhi_insn >> (for thumb2) and, quite possibly, thumb1_movhi_insn (for thumb1). There >> may well be additional changes for movqi variants as well. > > A general question: how should one test ARM

Fwd: Re: [PING][PATCH] Fix for PR 61561

2014-07-11 Thread Marat Zakirov
Thank to you all. Committed revision 212450. --Marat Original Message Subject:Re: [PING][PATCH] Fix for PR 61561 Date: Thu, 10 Jul 2014 14:01:24 +0100 From: Ramana Radhakrishnan To: Marat Zakirov , "gcc-patches@gcc.gnu.org" CC: Richard Earnsha

Re: [PATCH] Fix for PR 61561

2014-07-10 Thread Ramana Radhakrishnan
On Thu, Jun 19, 2014 at 9:19 PM, Yuri Gribov wrote: >> Thirdly, we also need to fix movhi_bytes (for pre-v4) thumb2_movhi_insn >> (for thumb2) and, quite possibly, thumb1_movhi_insn (for thumb1). There >> may well be additional changes for movqi variants as well. > > A general question: how shoul

Re: [PING][PATCH] Fix for PR 61561

2014-07-10 Thread Ramana Radhakrishnan
On 30/06/14 16:21, Marat Zakirov wrote: Thank for your attention. This is OK for trunk - Sorry about the delayed response. Ramana Marat.

[PING v2][PATCH] Fix for PR 61561

2014-07-10 Thread Marat Zakirov
Original Message Subject:[PING][PATCH] Fix for PR 61561 Date: Mon, 30 Jun 2014 19:21:49 +0400 From: Marat Zakirov To: gcc-patches@gcc.gnu.org CC: Ramana Radhakrishnan , Richard Earnshaw , Kyrill Tkachov , Slava Garbuzov , Yuri Gribov , mara...@gmail.com

[PING][PATCH] Fix for PR 61561

2014-06-30 Thread Marat Zakirov
This is a reminder message on fix for PR 61561 which is ICE while compiling something which is valid* 'C' code. (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61561). Ramana, Richard, I am very appreciated for your attention and error indication, your work made my patch simple and tiny. And I h

[PATCH] Fix for PR 61561

2014-06-23 Thread Marat Zakirov
Hi all, Here's my new patch for PR 61561 (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61561). Which fixes ICE appeared due to QI/HI pattern lack in arm.md for stack pointer register. Reg. tested on arm-v7. --Marat arm.diff Description: Binary data

Re: [PATCH] Fix for PR 61561

2014-06-19 Thread Yuri Gribov
> Thirdly, we also need to fix movhi_bytes (for pre-v4) thumb2_movhi_insn > (for thumb2) and, quite possibly, thumb1_movhi_insn (for thumb1). There > may well be additional changes for movqi variants as well. A general question: how should one test ARM backend patches? Is it enough to regtest ARM

Re: [PATCH] Fix for PR 61561

2014-06-19 Thread Ramana Radhakrishnan
On 19/06/14 16:12, Kyrill Tkachov wrote: On 19/06/14 16:05, Marat Zakirov wrote: Hi all, Here's a patch for PR 61561 (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61561). It fixes ICE. Thanks for your contribution. However, this is *really* not the way to submit a patch and is the sort

Re: [PATCH] Fix for PR 61561

2014-06-19 Thread Richard Earnshaw
On 19/06/14 16:05, Marat Zakirov wrote: > Hi all, > > Here's a patch for PR 61561 > (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61561). > > It fixes ICE. > > Reg. tested on arm15. > > --Marat > > > arm.md.diff.diff > > > gcc/ChangeLog: > > 2014-06-19 Marat Zakirov > > * config

Re: [PATCH] Fix for PR 61561

2014-06-19 Thread Yuri Gribov
> + (if_then_else (match_operand 1 "const_int_operand" > "") > +(const_string "mov_imm" ) > +(const_string "mov_reg"))])] Why not just mov_reg? > * config/arm/arm.md: New templates see pr6156

Re: [PATCH] Fix for PR 61561

2014-06-19 Thread Kyrill Tkachov
On 19/06/14 16:05, Marat Zakirov wrote: Hi all, Here's a patch for PR 61561 (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61561). It fixes ICE. Reg. tested on arm15. CC'ing the arm maintainers... Kyrill --Marat

[PATCH] Fix for PR 61561

2014-06-19 Thread Marat Zakirov
Hi all, Here's a patch for PR 61561 (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61561). It fixes ICE. Reg. tested on arm15. --Marat arm.md.diff.diff Description: Binary data