Re: [PATCH] Fix format_integer (PR tree-optimization/78586)

2016-11-29 Thread Jeff Law
On 11/29/2016 12:48 PM, Jakub Jelinek wrote: Hi! As mentioned in the PR, the LSHIFT_EXPR computation of values that will need longest or shortest string is both incorrect (it shifts integer_one_node left, so for precisions above precision of integer it returns 0 (not to mention that it is invali

Re: [PATCH] Fix format_integer (PR tree-optimization/78586)

2016-11-29 Thread Martin Sebor
On 11/29/2016 12:48 PM, Jakub Jelinek wrote: Hi! As mentioned in the PR, the LSHIFT_EXPR computation of values that will need longest or shortest string is both incorrect (it shifts integer_one_node left, so for precisions above precision of integer it returns 0 (not to mention that it is invali

[PATCH] Fix format_integer (PR tree-optimization/78586)

2016-11-29 Thread Jakub Jelinek
Hi! As mentioned in the PR, the LSHIFT_EXPR computation of values that will need longest or shortest string is both incorrect (it shifts integer_one_node left, so for precisions above precision of integer it returns 0 (not to mention that it is invalid GENERIC, because the types of first operand a