Re: [PATCH] Fix libgo build (was Re: [PATCH v3] PR85678: Change default to -fno-common)

2019-11-21 Thread Jakub Jelinek
On Thu, Nov 21, 2019 at 11:40:33AM +, Wilco Dijkstra wrote: > Hi Rainer, > > >> ld: warning: symbol 'err' has differing types: > >> (file /var/tmp//ccWQCyMc.o type=OBJT; file /lib/libc.so > >> type=FUNC); > >> /var/tmp//ccWQCyMc.o definition taken > > So are glob and err

Re: [PATCH] Fix libgo build (was Re: [PATCH v3] PR85678: Change default to -fno-common)

2019-11-21 Thread Wilco Dijkstra
Hi Rainer, >> ld: warning: symbol 'err' has differing types: >> (file /var/tmp//ccWQCyMc.o type=OBJT; file /lib/libc.so type=FUNC); >> /var/tmp//ccWQCyMc.o definition taken So are glob and err somehow exported as globals by your GLIBC? I don't think those are standard

Re: [PATCH] Fix libgo build (was Re: [PATCH v3] PR85678: Change default to -fno-common)

2019-11-21 Thread Jakub Jelinek
On Thu, Nov 21, 2019 at 12:03:19PM +0100, Rainer Orth wrote: > I'm seeing those, too, plus the following that are apparently only > diagnosed by Solaris ld: > > +FAIL: gcc.c-torture/execute/20030913-1.c -O0 (test for excess errors) > +FAIL: gcc.c-torture/execute/20030913-1.c -O1 (test for

Re: [PATCH] Fix libgo build (was Re: [PATCH v3] PR85678: Change default to -fno-common)

2019-11-21 Thread Rainer Orth
Hi Jakub, > On Thu, Nov 21, 2019 at 01:41:47AM +0100, Rainer Orth wrote: >> Same on sparc-sun-solaris2.11 and i386-pc-solaris2.11. >> >> There where quite a number of non-Go regressions all over the place. >> Many are like this: >> >> FAIL: gcc.c-torture/execute/complex-6.c -O0 (test for

Re: [PATCH] Fix libgo build (was Re: [PATCH v3] PR85678: Change default to -fno-common)

2019-11-20 Thread Ian Lance Taylor
On Wed, Nov 20, 2019 at 4:18 PM Jakub Jelinek wrote: > > On Tue, Nov 05, 2019 at 05:17:10PM +, Wilco Dijkstra wrote: > > Passes bootstrap and regress on AArch64 and x64. OK for commit? > > This broke bootstrap on x86_64-linux as well as i686-linux (guess all > targets that go supports). > The

Re: [PATCH] Fix libgo build (was Re: [PATCH v3] PR85678: Change default to -fno-common)

2019-11-20 Thread Jakub Jelinek
On Thu, Nov 21, 2019 at 01:41:47AM +0100, Rainer Orth wrote: > Same on sparc-sun-solaris2.11 and i386-pc-solaris2.11. > > There where quite a number of non-Go regressions all over the place. > Many are like this: > > FAIL: gcc.c-torture/execute/complex-6.c -O0 (test for excess errors) > >

Re: [PATCH] Fix libgo build (was Re: [PATCH v3] PR85678: Change default to -fno-common)

2019-11-20 Thread Rainer Orth
Hi Jakub, > On Tue, Nov 05, 2019 at 05:17:10PM +, Wilco Dijkstra wrote: >> Passes bootstrap and regress on AArch64 and x64. OK for commit? > > This broke bootstrap on x86_64-linux as well as i686-linux (guess all > targets that go supports). indeed: just saw it on Solaris with the native ld.

[PATCH] Fix libgo build (was Re: [PATCH v3] PR85678: Change default to -fno-common)

2019-11-20 Thread Jakub Jelinek
On Tue, Nov 05, 2019 at 05:17:10PM +, Wilco Dijkstra wrote: > Passes bootstrap and regress on AArch64 and x64. OK for commit? This broke bootstrap on x86_64-linux as well as i686-linux (guess all targets that go supports). The following patch fixes it for me, though not sure which *.c file is