Re: [PATCH] Fix nrv-1.c false failure on aarch64.

2017-10-27 Thread Egeyar Bagcioglu
On 10/26/2017 05:03 PM, Jeff Law wrote: On 10/18/2017 10:59 AM, Egeyar Bagcioglu wrote: Hello, Test case "guality.exp=nrv-1.c" fails on aarch64. Optimizations reorder the instructions and cause the value of a variable to be checked before its first assignment. The following patch is moving the

Re: [PATCH] Fix nrv-1.c false failure on aarch64.

2017-10-26 Thread Jeff Law
On 10/18/2017 10:59 AM, Egeyar Bagcioglu wrote: > Hello, > > Test case "guality.exp=nrv-1.c" fails on aarch64. Optimizations reorder > the instructions and cause the value of a variable to be checked before > its first assignment. The following patch is moving the > break point to the end of the

Re: [PATCH] Fix nrv-1.c false failure on aarch64.

2017-10-24 Thread Egeyar Bagcioglu
On 10/20/2017 03:13 PM, Richard Earnshaw (lists) wrote: On 19/10/17 09:14, Richard Biener wrote: I guess Alex work on stmt frontiers will fix this instance? Thank you all for the reviews. I fetched Alex's branches in gcc (aoliva/SFN) and in binutils (users/aoliva/SFN). Using gcc and binutils

Re: [PATCH] Fix nrv-1.c false failure on aarch64.

2017-10-20 Thread Richard Earnshaw (lists)
On 20/10/17 13:45, Alexandre Oliva wrote: > On Oct 19, 2017, "Richard Earnshaw (lists)" > wrote: > >> On 19/10/17 09:14, Richard Biener wrote: >>> I guess Alex work on stmt frontiers will fix this instance? > >> Don't stmt frontiers just enable you to identify exactly

Re: [PATCH] Fix nrv-1.c false failure on aarch64.

2017-10-20 Thread Alexandre Oliva
On Oct 19, 2017, "Richard Earnshaw (lists)" wrote: > On 19/10/17 09:14, Richard Biener wrote: >> I guess Alex work on stmt frontiers will fix this instance? > Don't stmt frontiers just enable you to identify exactly one stopping > point with each statement, so that you

Re: [PATCH] Fix nrv-1.c false failure on aarch64.

2017-10-19 Thread Richard Biener
On Thu, Oct 19, 2017 at 2:47 PM, Richard Earnshaw (lists) wrote: > On 19/10/17 09:14, Richard Biener wrote: >> On Wed, Oct 18, 2017 at 6:59 PM, Egeyar Bagcioglu >> wrote: >>> Hello, >>> >>> Test case "guality.exp=nrv-1.c" fails on aarch64.

Re: [PATCH] Fix nrv-1.c false failure on aarch64.

2017-10-19 Thread Richard Earnshaw (lists)
On 19/10/17 09:14, Richard Biener wrote: > On Wed, Oct 18, 2017 at 6:59 PM, Egeyar Bagcioglu > wrote: >> Hello, >> >> Test case "guality.exp=nrv-1.c" fails on aarch64. Optimizations reorder the >> instructions and cause the value of a variable to be checked before its

Re: [PATCH] Fix nrv-1.c false failure on aarch64.

2017-10-19 Thread Richard Biener
On Wed, Oct 18, 2017 at 6:59 PM, Egeyar Bagcioglu wrote: > Hello, > > Test case "guality.exp=nrv-1.c" fails on aarch64. Optimizations reorder the > instructions and cause the value of a variable to be checked before its > first assignment. The following patch is

[PATCH] Fix nrv-1.c false failure on aarch64.

2017-10-18 Thread Egeyar Bagcioglu
ubject: [PATCH] Fix nrv-1.c false failure on aarch64. Reordering instructions due to optimization flags is causing nrv-1.c to fail on aarch64. The value of the variable is checked before the assignment instruction is reached. This patch is moving the breakpoint to the end of the function to prevent