Re: [PATCH] Fix up sbitmap bitmap_{and,ior,xor} (PR target/55562)

2012-12-18 Thread Richard Henderson
On 12/18/2012 08:47 AM, Jakub Jelinek wrote: > 2012-12-18 Jakub Jelinek > > PR target/55562 > * sbitmap.c (bitmap_and, bitmap_xor, bitmap_ior): Return whether > dst sbitmap changed even if it doesn't have popcount. Ok. r~

Re: [PATCH] Fix up sbitmap bitmap_{and,ior,xor} (PR target/55562)

2012-12-18 Thread Lawrence Crowl
On 12/18/12, Jakub Jelinek wrote: > The bitmap unification changes apparently broke at least modulo > scheduling, which used sbitmap_a_and_b_cg functions, which > were replaced by bitmap_and. But, sbitmap_a_and_b_cg asserted > dst->popcount is NULL and returned whether dst sbitmap changed, > but

[PATCH] Fix up sbitmap bitmap_{and,ior,xor} (PR target/55562)

2012-12-18 Thread Jakub Jelinek
Hi! The bitmap unification changes apparently broke at least modulo scheduling, which used sbitmap_a_and_b_cg functions, which were replaced by bitmap_and. But, sbitmap_a_and_b_cg asserted dst->popcount is NULL and returned whether dst sbitmap changed, but bitmap_and returns always false if dst->p