Re: [PATCH] Improve debug info if tree DCE removes stores (PR debug/50317, fallout)

2012-09-05 Thread Alexandre Oliva
Hi, Richi, Sorry if this comes in late. I'd saved your message for careful analysis and I only got back to it now. On Aug 1, 2012, Richard Guenther richard.guent...@gmail.com wrote: On Fri, Dec 2, 2011 at 8:28 PM, Jakub Jelinek ja...@redhat.com wrote: PR debug/50317 * tree-ssa.c

Re: [PATCH] Improve debug info if tree DCE removes stores (PR debug/50317, fallout)

2012-08-01 Thread Richard Guenther
On Fri, Dec 2, 2011 at 8:28 PM, Jakub Jelinek ja...@redhat.com wrote: On Fri, Dec 02, 2011 at 02:27:40PM +0100, Richard Guenther wrote: This change seems wrong. We are turning valid gimple # DEBUG D#2 = transfer.0 [with addres taken] into invalid one # DEBUG D#2 = transfer.0 [without

Re: [PATCH] Improve debug info if tree DCE removes stores (PR debug/50317, fallout)

2011-12-03 Thread Richard Guenther
On Fri, Dec 2, 2011 at 8:28 PM, Jakub Jelinek ja...@redhat.com wrote: On Fri, Dec 02, 2011 at 02:27:40PM +0100, Richard Guenther wrote: This change seems wrong.  We are turning valid gimple # DEBUG D#2 = transfer.0  [with addres taken] into invalid one # DEBUG D#2 = transfer.0  [without

Re: [PATCH] Improve debug info if tree DCE removes stores (PR debug/50317)

2011-12-02 Thread Michael Matz
Hi, On Fri, 2 Dec 2011, Richard Guenther wrote: Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2011-12-01 Jakub Jelinek ja...@redhat.com PR debug/50317 * tree-ssa-dce.c (remove_dead_stmt): Add a debug stmt when removing as unnecessary a store

[PATCH] Improve debug info if tree DCE removes stores (PR debug/50317, fallout)

2011-12-02 Thread Jakub Jelinek
On Fri, Dec 02, 2011 at 02:27:40PM +0100, Richard Guenther wrote: This change seems wrong. We are turning valid gimple # DEBUG D#2 = transfer.0 [with addres taken] into invalid one # DEBUG D#2 = transfer.0 [without address taken] once you update that stmt with update_stmt you'll

[PATCH] Improve debug info if tree DCE removes stores (PR debug/50317)

2011-12-01 Thread Jakub Jelinek
Hi! As discussed in the PR, in 4.7 we regressed some GDB testcases, because previously unused addressable vars were first previously optimized into non-addressable and only afterwards removed (which results in correct debug stmts covering those assignments), but after some recent changes it is

Re: [PATCH] Improve debug info if tree DCE removes stores (PR debug/50317)

2011-12-01 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/01/11 09:49, Jakub Jelinek wrote: Hi! As discussed in the PR, in 4.7 we regressed some GDB testcases, because previously unused addressable vars were first previously optimized into non-addressable and only afterwards removed (which