Re: [PATCH] Improve spillcost of literal pool loads

2014-12-03 Thread H.J. Lu
On Tue, Dec 2, 2014 at 5:55 AM, H.J. Lu wrote: > On Tue, Dec 2, 2014 at 5:51 AM, H.J. Lu wrote: >> On Tue, Dec 2, 2014 at 3:34 AM, Wilco Dijkstra wrote: Jeff Law wrote: OK with the appropropriate ChangeLog entires. THe original for ira-costs.c was fine, so you just need the trivi

Re: [PATCH] Improve spillcost of literal pool loads

2014-12-02 Thread H.J. Lu
On Tue, Dec 2, 2014 at 5:51 AM, H.J. Lu wrote: > On Tue, Dec 2, 2014 at 3:34 AM, Wilco Dijkstra wrote: >>> Jeff Law wrote: >>> OK with the appropropriate ChangeLog entires. THe original for >>> ira-costs.c was fine, so you just need the trivial one for the testcase. >> >> ChangeLog below - Jiong

Re: [PATCH] Improve spillcost of literal pool loads

2014-12-02 Thread H.J. Lu
On Tue, Dec 2, 2014 at 3:34 AM, Wilco Dijkstra wrote: >> Jeff Law wrote: >> OK with the appropropriate ChangeLog entires. THe original for >> ira-costs.c was fine, so you just need the trivial one for the testcase. > > ChangeLog below - Jiong, could you commit for me please? > > 2014-12-02 Wilco

RE: [PATCH] Improve spillcost of literal pool loads

2014-12-02 Thread Wilco Dijkstra
> Jeff Law wrote: > OK with the appropropriate ChangeLog entires. THe original for > ira-costs.c was fine, so you just need the trivial one for the testcase. ChangeLog below - Jiong, could you commit for me please? 2014-12-02 Wilco Dijkstra * gcc/ira-costs.c (scan_one_insn): Improve

Re: [PATCH] Improve spillcost of literal pool loads

2014-12-01 Thread Jeff Law
On 11/28/14 07:10, Wilco Dijkstra wrote: Jeff Law wrote: Do you have a testcase that shows the expected improvements from this change? It's OK if it's specific to a target. Have you bootstrapped and regression tested this change? With a test for the testsuite and assuming it passes bootstrap a

RE: [PATCH] Improve spillcost of literal pool loads

2014-11-28 Thread Wilco Dijkstra
> Jeff Law wrote: > Do you have a testcase that shows the expected improvements from this > change? It's OK if it's specific to a target. > > Have you bootstrapped and regression tested this change? > > With a test for the testsuite and assuming it passes bootstrap and > regression testing, this

Re: [PATCH] Improve spillcost of literal pool loads

2014-10-29 Thread Jeff Law
On 10/29/14 07:21, Wilco Dijkstra wrote: This patch adjusts the spill cost of literal pool loads to reduce the chance of them being caller-saved (which is inefficient). Such loads should be rematerialized and thus should not include the cost of a spill store. This was done only on constants for

[PATCH] Improve spillcost of literal pool loads

2014-10-29 Thread Wilco Dijkstra
This patch adjusts the spill cost of literal pool loads to reduce the chance of them being caller-saved (which is inefficient). Such loads should be rematerialized and thus should not include the cost of a spill store. This was done only on constants for which legitimate_constant_p is true, howe