Re: [PATCH] MATCH: Make zero_one_valued_p non-recusive fully

2023-09-18 Thread Jakub Jelinek via Gcc-patches
On Mon, Sep 18, 2023 at 11:04:16AM +0200, Richard Biener via Gcc-patches wrote: > > Note genmatch should warn (or error out) if this gets detected so I filed > > PR 111446 > > which I will be looking into next week or the week after so we don't run > > into > > this issue again. > > > >

Re: [PATCH] MATCH: Make zero_one_valued_p non-recusive fully

2023-09-18 Thread Richard Biener via Gcc-patches
On Sun, Sep 17, 2023 at 11:41 PM Andrew Pinski via Gcc-patches wrote: > > So it turns out VN can't handle any kind of recusion for match. In this > case we have `b = a & -1` and we try to match a as being zero_one_valued_p > and VN returns b as being the value and we just go into an infinite loop

[PATCH] MATCH: Make zero_one_valued_p non-recusive fully

2023-09-17 Thread Andrew Pinski via Gcc-patches
So it turns out VN can't handle any kind of recusion for match. In this case we have `b = a & -1` and we try to match a as being zero_one_valued_p and VN returns b as being the value and we just go into an infinite loop at this point. OK? Bootstrapped and tested on x86_64-linux-gnu with no