On Tue, 13 Nov 2018, Maciej W. Rozycki wrote:
> On Sun, 11 Nov 2018, Fredrik Noring wrote:
>
> > ../../../../libsanitizer/sanitizer_common/sanitizer_platform_limits_linux.cc:71:1:
> > note: in expansion of macro ?COMPILER_CHECK?
> >71 | COMPILER_CHECK(struct_kernel_stat_sz == sizeof(struct
On Sun, 11 Nov 2018, Fredrik Noring wrote:
> ../../../../libsanitizer/sanitizer_common/sanitizer_platform_limits_linux.cc:71:1:
> note: in expansion of macro ‘COMPILER_CHECK’
>71 | COMPILER_CHECK(struct_kernel_stat_sz == sizeof(struct stat));
> | ^~
I guess
Hi Matthew,
> [ As mentioned in the commit message, the test was done with GCC 8.2.0
> since there was an unrelated problem compiling some sanitizer component
> at the time. I will try to test a current GCC version during the weekend. ]
The compilation problem, more specifically, is
In file
Thank you for your reviews, Matthew,
> Has your copyright assignment come through for GCC? I can't access
> the copyright info at the moment to check myself. Obviously that will
> be a blocker otherwise.
I filled in and posted request-assign.future to the FSF 1 October, but I
have not heard from
Hi Fredrik,
> Many thanks for your prompt review, Maciej!
Maciej, I am equally grateful for you stepping in to get Fredrik's
contribution reviewed. I have taken a look through and have no
additional comments. I'm going to be travelling this weekend so
I'd like to ask Maciej to take a quick
Many thanks for your prompt review, Maciej!
> > * gcc/config/mips/mips.c (mips_reorg_process_insns)
> > (mips_option_override): Default to working around R5900
> > errata only if the processor was selected explicitly.
>
> I think this only describes the `mips_option_override'
Hi Fredrik,
Thank you for your submission. Your change looks very good to me, except
for a bunch of minor nits in your proposed ChangeLog entry.
> * gcc/config/mips/mips.c (mips_reorg_process_insns)
> (mips_option_override): Default to working around R5900
> errata only
The short loop bug under certain conditions causes loops to
execute only once or twice, due to a hardware bug in the R5900 chip.
`-march=r5900' already enables the R5900 short loop workaround.
However, the R5900 ISA and most other MIPS ISAs are mutually
exclusive since R5900-specific instructions
