Re: [PATCH] Objective-C++ : Allow prefix attrs on linkage specs.

2020-12-01 Thread Jason Merrill via Gcc-patches
On 11/28/20 4:53 AM, Iain Sandoe wrote: (resending - this didn’t seem to reach gcc-patches@) Jason Merrill wrote: On Mon, Nov 23, 2020 at 8:52 AM Iain Sandoe wrote: Jason Merrill wrote: (NOTE: likewise,   ^~~ starting indent is below ‘int’ for a fixed spacing font) === I’m inclined to

Re: [PATCH] Objective-C++ : Allow prefix attrs on linkage specs.

2020-11-30 Thread Jason Merrill via Gcc-patches
On 11/27/20 6:08 PM, Iain Sandoe wrote: Jason Merrill wrote: On Mon, Nov 23, 2020 at 8:52 AM Iain Sandoe wrote: Jason Merrill wrote: (NOTE: likewise,   ^~~ starting indent is below ‘int’ for a fixed spacing font) === I’m inclined to think that the second is more useful, but have

Re: [PATCH] Objective-C++ : Allow prefix attrs on linkage specs.

2020-11-28 Thread Iain Sandoe
(resending - this didn’t seem to reach gcc-patches@) Jason Merrill wrote: On Mon, Nov 23, 2020 at 8:52 AM Iain Sandoe wrote: Jason Merrill wrote: (NOTE: likewise, ^~~ starting indent is below ‘int’ for a fixed spacing font) === I’m inclined to think that the second is more useful,

Re: [PATCH] Objective-C++ : Allow prefix attrs on linkage specs.

2020-11-23 Thread Jason Merrill via Gcc-patches
On Mon, Nov 23, 2020 at 8:52 AM Iain Sandoe wrote: > Jason Merrill wrote: > > > On 11/7/20 10:11 AM, Iain Sandoe wrote: > > >> + warning_at (token1->location, OPT_Wattributes, "attributes > are" > >> + " only permitted in this position for > Objective-C++," > >> +

Re: [PATCH] Objective-C++ : Allow prefix attrs on linkage specs.

2020-11-23 Thread Iain Sandoe
Jason Merrill wrote: On 11/7/20 10:11 AM, Iain Sandoe wrote: + warning_at (token1->location, OPT_Wattributes, "attributes are" + " only permitted in this position for Objective-C++," + " ignored"); It would be nice for the

Re: [PATCH] Objective-C++ : Allow prefix attrs on linkage specs.

2020-11-20 Thread Jason Merrill via Gcc-patches
On 11/7/20 10:11 AM, Iain Sandoe wrote: Hi, For Objective-C++/C, we cater for the possibility that a class interface (@interface) might be preceded by prefix attributes. In the case of Objective-C++, the reference implementation (a.k.a. clang) also allows (and combines) prefix attributes that

Re: [PATCH] Objective-C++ : Allow prefix attrs on linkage specs.

2020-11-10 Thread Jeff Law via Gcc-patches
On 11/7/20 8:11 AM, Iain Sandoe wrote: > Hi, > > For Objective-C++/C, we cater for the possibility that a class interface > (@interface) might be preceded by prefix attributes. In the case of > Objective-C++, the reference implementation (a.k.a. clang) also allows > (and combines) prefix

[PATCH] Objective-C++ : Allow prefix attrs on linkage specs.

2020-11-07 Thread Iain Sandoe
Hi, For Objective-C++/C, we cater for the possibility that a class interface (@interface) might be preceded by prefix attributes. In the case of Objective-C++, the reference implementation (a.k.a. clang) also allows (and combines) prefix attributes that precede a linkage specification (but only