Re: [PATCH] OpenACC use_device clause ICE fix

2016-01-25 Thread Chung-Lin Tang
On 2016/1/25 7:06 PM, Jakub Jelinek wrote: > The following ICEs without the patch and works with it, so I think it is > better: > > 2016-01-25 Jakub Jelinek > > * omp-low.c (lower_omp_target) : Set > DECL_VALUE_EXPR of new_var even for the non-array case. Look >

Re: [PATCH] OpenACC use_device clause ICE fix

2016-01-25 Thread Chung-Lin Tang
On 2016/1/22 12:32 AM, Jakub Jelinek wrote: > On Thu, Jan 21, 2016 at 10:22:19PM +0800, Chung-Lin Tang wrote: >> On 2016/1/20 09:17 PM, Bernd Schmidt wrote: >>> On 01/05/2016 02:15 PM, Chung-Lin Tang wrote: * omp-low.c (scan_sharing_clauses): Call add_local_decl() for

Re: [PATCH] OpenACC use_device clause ICE fix

2016-01-25 Thread Jakub Jelinek
On Mon, Jan 25, 2016 at 05:52:56PM +0900, Chung-Lin Tang wrote: > I've attached a small testcase that triggers the ICE under -fopenacc. This > stll > happens under current trunk. Then I think I'd prefer (untested so far): 2016-01-25 Jakub Jelinek * omp-low.c

Re: [PATCH] OpenACC use_device clause ICE fix

2016-01-25 Thread Jakub Jelinek
On Mon, Jan 25, 2016 at 11:02:05AM +0100, Jakub Jelinek wrote: > On Mon, Jan 25, 2016 at 10:58:17AM +0100, Jakub Jelinek wrote: > > --- gcc/testsuite/c-c++-common/goacc/use_device-1.c.jj 2016-01-25 > > 10:56:33.472310437 +0100 > > +++ gcc/testsuite/c-c++-common/goacc/use_device-1.c

Re: [PATCH] OpenACC use_device clause ICE fix

2016-01-25 Thread Jakub Jelinek
On Mon, Jan 25, 2016 at 10:58:17AM +0100, Jakub Jelinek wrote: > --- gcc/testsuite/c-c++-common/goacc/use_device-1.c.jj2016-01-25 > 10:56:33.472310437 +0100 > +++ gcc/testsuite/c-c++-common/goacc/use_device-1.c 2016-01-25 > 10:56:43.128176481 +0100 > @@ -0,0 +1,15 @@ > +/* { dg-do

Re: [PATCH] OpenACC use_device clause ICE fix

2016-01-21 Thread Chung-Lin Tang
On 2016/1/20 09:17 PM, Bernd Schmidt wrote: > On 01/05/2016 02:15 PM, Chung-Lin Tang wrote: >> * omp-low.c (scan_sharing_clauses): Call add_local_decl() for >> use_device/use_device_ptr variables. > > It looks vaguely plausible, but if everything is part of the host > function, why make a

Re: [PATCH] OpenACC use_device clause ICE fix

2016-01-21 Thread Jakub Jelinek
On Thu, Jan 21, 2016 at 10:22:19PM +0800, Chung-Lin Tang wrote: > On 2016/1/20 09:17 PM, Bernd Schmidt wrote: > > On 01/05/2016 02:15 PM, Chung-Lin Tang wrote: > >> * omp-low.c (scan_sharing_clauses): Call add_local_decl() for > >> use_device/use_device_ptr variables. > > > > It looks

Re: [PATCH] OpenACC use_device clause ICE fix

2016-01-21 Thread Bernd Schmidt
On 01/21/2016 03:22 PM, Chung-Lin Tang wrote: On 2016/1/20 09:17 PM, Bernd Schmidt wrote: On 01/05/2016 02:15 PM, Chung-Lin Tang wrote: * omp-low.c (scan_sharing_clauses): Call add_local_decl() for use_device/use_device_ptr variables. It looks vaguely plausible, but if everything

Re: [PATCH] OpenACC use_device clause ICE fix

2016-01-20 Thread Bernd Schmidt
On 01/05/2016 02:15 PM, Chung-Lin Tang wrote: * omp-low.c (scan_sharing_clauses): Call add_local_decl() for use_device/use_device_ptr variables. It looks vaguely plausible, but if everything is part of the host function, why make a copy of the decl at all? I.e. what happens if

Re: [PATCH] OpenACC use_device clause ICE fix

2016-01-18 Thread Chung-Lin Tang
Ping. On 2016/1/5 10:15 PM, Chung-Lin Tang wrote: > Hi, > we've been encountering an ICE for OpenACC host_data sections, which > has a use_device() clause similar to OpenMP use_device_ptr. > > The ICE happens in make_decl_rtl() for scan-created variables, which IIUC, > should not be entered at

[PATCH] OpenACC use_device clause ICE fix

2016-01-05 Thread Chung-Lin Tang
Hi, we've been encountering an ICE for OpenACC host_data sections, which has a use_device() clause similar to OpenMP use_device_ptr. The ICE happens in make_decl_rtl() for scan-created variables, which IIUC, should not be entered at all for automatic variables. I believe the problem is, unlike