Re: [PATCH] PR fortran/78618 -- RANK() should not ICE

2016-12-03 Thread Steve Kargl
On Sat, Dec 03, 2016 at 05:58:02PM +0100, Andreas Schwab wrote: > On Dez 01 2016, Steve Kargl wrote: > > > PR fortran/78618 > > * gfortran.dg/char_conversion.f90: New test. > > That test still crashes the compiler on m68k: > > 0xb40a7f crash_signal >

Re: [PATCH] PR fortran/78618 -- RANK() should not ICE

2016-12-03 Thread Andreas Schwab
On Dez 01 2016, Steve Kargl wrote: > PR fortran/78618 > * gfortran.dg/char_conversion.f90: New test. That test still crashes the compiler on m68k: /daten/aranym/gcc/gcc-20161203/gcc/testsuite/gfortran.dg/char_conversion.f90:8:30: Error: Character

Re: [PATCH] PR fortran/78618 -- RANK() should not ICE

2016-12-02 Thread Steve Kargl
On Fri, Dec 02, 2016 at 07:39:33PM +0100, Janus Weil wrote: > > Testing went well. Committed as r243201. > Thanks for reviewing my patch, and more importantly thanks for your patch. -- Steve

Re: [PATCH] PR fortran/78618 -- RANK() should not ICE

2016-12-02 Thread Janus Weil
2016-12-02 19:06 GMT+01:00 Janus Weil : > 2016-12-02 18:13 GMT+01:00 Steve Kargl : >>> >> > The attached patch fixes an ICE, a nearby whitespace issue, and >>> >> > removed the ATTRIBUTE_UNUSED tag. THe change has passed regression >>> >> >

Re: [PATCH] PR fortran/78618 -- RANK() should not ICE

2016-12-02 Thread Janus Weil
2016-12-02 18:13 GMT+01:00 Steve Kargl : >> >> > The attached patch fixes an ICE, a nearby whitespace issue, and >> >> > removed the ATTRIBUTE_UNUSED tag. THe change has passed regression >> >> > testing on x86_64-*-freebsd. Ok to commit? >> >> >> >> huh, I

Re: [PATCH] PR fortran/78618 -- RANK() should not ICE

2016-12-02 Thread Steve Kargl
On Fri, Dec 02, 2016 at 06:00:48PM +0100, Janus Weil wrote: > 2016-12-02 17:30 GMT+01:00 Steve Kargl : > > On Fri, Dec 02, 2016 at 04:47:19PM +0100, Janus Weil wrote: > >> Hi Steve, > >> > >> 2016-12-02 2:33 GMT+01:00 Steve Kargl

Re: [PATCH] PR fortran/78618 -- RANK() should not ICE

2016-12-02 Thread Janus Weil
2016-12-02 17:30 GMT+01:00 Steve Kargl : > On Fri, Dec 02, 2016 at 04:47:19PM +0100, Janus Weil wrote: >> Hi Steve, >> >> 2016-12-02 2:33 GMT+01:00 Steve Kargl : >> > The attached patch fixes an ICE, a nearby whitespace issue,

Re: [PATCH] PR fortran/78618 -- RANK() should not ICE

2016-12-02 Thread Steve Kargl
On Fri, Dec 02, 2016 at 04:47:19PM +0100, Janus Weil wrote: > Hi Steve, > > 2016-12-02 2:33 GMT+01:00 Steve Kargl : > > The attached patch fixes an ICE, a nearby whitespace issue, and > > removed the ATTRIBUTE_UNUSED tag. THe change has passed regression > >

Re: [PATCH] PR fortran/78618 -- RANK() should not ICE

2016-12-02 Thread Janus Weil
Hi Steve, 2016-12-02 2:33 GMT+01:00 Steve Kargl : > The attached patch fixes an ICE, a nearby whitespace issue, and > removed the ATTRIBUTE_UNUSED tag. THe change has passed regression > testing on x86_64-*-freebsd. Ok to commit? huh, I don't really

[PATCH] PR fortran/78618 -- RANK() should not ICE

2016-12-01 Thread Steve Kargl
The attached patch fixes an ICE, a nearby whitespace issue, and removed the ATTRIBUTE_UNUSED tag. THe change has passed regression testing on x86_64-*-freebsd. Ok to commit? 2016-12-01 Steven G. Kargl PR fortran/78618 * check.c (gfc_check_rank): Remove