Re: [PATCH] PR fortran/90166 -- check F2018:C1547

2019-04-22 Thread Dominique d'Humières
> Le 21 avr. 2019 à 18:02, Steve Kargl a > écrit : > > On Sat, Apr 20, 2019 at 09:51:11PM +0200, Dominique d'Humières wrote: >> OK I missed the previous error. However I am still puzzled by (2): >> >> + >> +found outside of a module >> > > Why are you puzzled? Did you read the patch?

Re: [PATCH] PR fortran/90166 -- check F2018:C1547

2019-04-21 Thread Steve Kargl
On Sat, Apr 20, 2019 at 09:51:11PM +0200, Dominique d'Humières wrote: > OK I missed the previous error. However I am still puzzled by (2): > > + > +found outside of a module > Why are you puzzled? Did you read the patch? The entire error message is + gfc_error ("MODULE prefix at %C

Re: [PATCH] PR fortran/90166 -- check F2018:C1547

2019-04-20 Thread Dominique d'Humières
OK I missed the previous error. However I am still puzzled by (2): + +found outside of a module Dominique > Le 20 avr. 2019 à 21:18, Steve Kargl a > écrit : > > On Sat, Apr 20, 2019 at 09:57:34AM -0700, Steve Kargl wrote: >> On Sat, Apr 20, 2019 at 05:38:34PM +0200, Dominique d'Humières

Re: [PATCH] PR fortran/90166 -- check F2018:C1547

2019-04-20 Thread Steve Kargl
On Sat, Apr 20, 2019 at 09:57:34AM -0700, Steve Kargl wrote: > On Sat, Apr 20, 2019 at 05:38:34PM +0200, Dominique d'Humières wrote: > > > > The changes in gfortran.dg/submodule_22.f08 look weird: > > (1) is the error in the CONTAINS of a SUBMODULE invalid? > > From > > > > * decl.c

Re: [PATCH] PR fortran/90166 -- check F2018:C1547

2019-04-20 Thread Paul Richard Thomas
It looks good to me, modulo Dominique's query. OK for trunk (note from Richi - still aiming for zero P1 bugs so you're good to go). Thanks Paul On Fri, 19 Apr 2019 at 22:44, Steve Kargl wrote: > > The attached patch fixes PR fortran/91066. The original > code was feeding a nonsense string of

Re: [PATCH] PR fortran/90166 -- check F2018:C1547

2019-04-20 Thread Steve Kargl
On Sat, Apr 20, 2019 at 05:38:34PM +0200, Dominique d'Humières wrote: > > The changes in gfortran.dg/submodule_22.f08 look weird: > (1) is the error in the CONTAINS of a SUBMODULE invalid? > From > > * decl.c (in_module_or_interface): New function to check that the > current state is

Re: [PATCH] PR fortran/90166 -- check F2018:C1547

2019-04-20 Thread Dominique d'Humières
Hi Steve, The changes in gfortran.dg/submodule_22.f08 look weird: (1) is the error in the CONTAINS of a SUBMODULE invalid? From * decl.c (in_module_or_interface): New function to check that the current state is in a module, submodule, or interface. it should not, should it? (2)

[PATCH] PR fortran/90166 -- check F2018:C1547

2019-04-19 Thread Steve Kargl
The attached patch fixes PR fortran/91066. The original code was feeding a nonsense string of tokens to the assembler causing it to toss its cookies. It turns out that gfortran was not enforcing the constraint C1547 from Fortran 2018. The attached patch now performs that check. Regression