Re: [PATCH] PR libstdc++/53984 handle exceptions in basic_istream::sentry

2017-08-10 Thread Jonathan Wakely
On 26/07/17 23:06 +0100, Jonathan Wakely wrote: On 26/07/17 20:14 +0200, Paolo Carlini wrote: Hi again, On 26/07/2017 16:27, Paolo Carlini wrote: Hi, On 26/07/2017 16:21, Andreas Schwab wrote: ERROR: 27_io/basic_fstream/53984.cc: unknown dg option: dg-require-file-io 18 {} for " dg-require-f

Re: [PATCH] PR libstdc++/53984 handle exceptions in basic_istream::sentry

2017-07-27 Thread Bin.Cheng
On Wed, Jul 26, 2017 at 11:06 PM, Jonathan Wakely wrote: > On 26/07/17 20:14 +0200, Paolo Carlini wrote: >> >> Hi again, >> >> On 26/07/2017 16:27, Paolo Carlini wrote: >>> >>> Hi, >>> >>> On 26/07/2017 16:21, Andreas Schwab wrote: ERROR: 27_io/basic_fstream/53984.cc: unknown dg option:

Re: [PATCH] PR libstdc++/53984 handle exceptions in basic_istream::sentry

2017-07-26 Thread Jonathan Wakely
On 26/07/17 20:14 +0200, Paolo Carlini wrote: Hi again, On 26/07/2017 16:27, Paolo Carlini wrote: Hi, On 26/07/2017 16:21, Andreas Schwab wrote: ERROR: 27_io/basic_fstream/53984.cc: unknown dg option: dg-require-file-io 18 {} for " dg-require-file-io 18 "" " Should be already fixed, a trivia

Re: [PATCH] PR libstdc++/53984 handle exceptions in basic_istream::sentry

2017-07-26 Thread Ville Voutilainen
On 26 July 2017 at 21:14, Paolo Carlini wrote: > Hi again, > > On 26/07/2017 16:27, Paolo Carlini wrote: >> >> Hi, >> >> On 26/07/2017 16:21, Andreas Schwab wrote: >>> >>> ERROR: 27_io/basic_fstream/53984.cc: unknown dg option: >>> dg-require-file-io 18 {} for " dg-require-file-io 18 "" " >> >> Sh

Re: [PATCH] PR libstdc++/53984 handle exceptions in basic_istream::sentry

2017-07-26 Thread Paolo Carlini
Hi again, On 26/07/2017 16:27, Paolo Carlini wrote: Hi, On 26/07/2017 16:21, Andreas Schwab wrote: ERROR: 27_io/basic_fstream/53984.cc: unknown dg option: dg-require-file-io 18 {} for " dg-require-file-io 18 "" " Should be already fixed, a trivial typo. ... but now the new test simply fails

Re: [PATCH] PR libstdc++/53984 handle exceptions in basic_istream::sentry

2017-07-26 Thread Paolo Carlini
Hi, On 26/07/2017 16:21, Andreas Schwab wrote: ERROR: 27_io/basic_fstream/53984.cc: unknown dg option: dg-require-file-io 18 {} for " dg-require-file-io 18 "" " Should be already fixed, a trivial typo. Thanks, Paolo.

Re: [PATCH] PR libstdc++/53984 handle exceptions in basic_istream::sentry

2017-07-26 Thread Andreas Schwab
On Jul 25 2017, Jonathan Wakely wrote: > diff --git a/libstdc++-v3/testsuite/27_io/basic_fstream/53984.cc > b/libstdc++-v3/testsuite/27_io/basic_fstream/53984.cc > new file mode 100644 > index 000..e84072e > --- /dev/null > +++ b/libstdc++-v3/testsuite/27_io/basic_fstream/53984.cc > @@ -0,0

[PATCH] PR libstdc++/53984 handle exceptions in basic_istream::sentry

2017-07-25 Thread Jonathan Wakely
The standard says that formatted/unformatted input operations should catch any exceptions, set iostate bits in the istream, and rethrow if the exception mask says to do so. We're failing to do that when the exception happens in the istream::sentry constructor, while it extracts characters to skip