Re: [PATCH] PR target/50038 fix: redundant zero extensions removal

2011-12-16 Thread Eric Botcazou
2011-12-15 Enkovich Ilya ilya.enkov...@intel.com PR target/50038 * implicit-zee.c: Delete. * ree.c: New file. * Makefile.in: Replace implicit-zee.c with ree.c. * config/i386/i386.c (ix86_option_override_internal): Set flag_ree for 32 bit platform.

Re: [PATCH] PR target/50038 fix: redundant zero extensions removal

2011-12-12 Thread Eric Botcazou
Here is a patch wich introduces new pass 'ree' based on pass 'implicit_zee' as was discussed above. Thanks. 2011-11-22 Enkovich Ilya ilya.enkov...@intel.com PR target/50038 * implicit-zee.c: Delete. * ree.c: New file. * Makefile.in: Replace implicit-zee.c with

Re: [PATCH] PR target/50038 fix: redundant zero extensions removal

2011-11-30 Thread Ilya Enkovich
Ping 2011/11/22 Ilya Enkovich enkovich@gmail.com: 2011/11/11 Eric Botcazou ebotca...@adacore.com: I have already signed copyright agreement with the FSF. Will I need the separate one for this particular commit? No, if your contributions are already covered by a copyright agreement with

Re: [PATCH] PR target/50038 fix: redundant zero extensions removal

2011-11-16 Thread Sergey Ostanevich
Eric, I will follow up while Ilya is on vacation. I can see only one patch along the dicussion so I will use it, making changes to follow phase renaming and documentation? I am covered by FSF agreement too, on the same Intel's list as Ilya. regards, Sergos On Fri, Nov 11, 2011 at 2:12 PM,

Re: [PATCH] PR target/50038 fix: redundant zero extensions removal

2011-11-11 Thread Eric Botcazou
Great! I'll be back with patch covering all non functional changes. Will it be OK to have everything in one patch (including current functional changes) or I should split it? Let's also rename the file while we are at it. I'd suggest Redundant Extension Elimination for the name of the pass,

Re: [PATCH] PR target/50038 fix: redundant zero extensions removal

2011-11-11 Thread Ilya Enkovich
Hello Eric, 2011/11/11 Eric Botcazou ebotca...@adacore.com: Great! I'll be back with patch covering all non functional changes. Will it be OK to have everything in one patch (including current functional changes) or I should split it? Let's also rename the file while we are at it.  I'd

Re: [PATCH] PR target/50038 fix: redundant zero extensions removal

2011-11-11 Thread Eric Botcazou
I have already signed copyright agreement with the FSF. Will I need the separate one for this particular commit? No, if your contributions are already covered by a copyright agreement with the FSF, nothing more needs to be done. -- Eric Botcazou

Re: [PATCH] PR target/50038 fix: redundant zero extensions removal

2011-11-10 Thread Eric Botcazou
Initial aim of the pass was to remove zero extentions redundant due to implicit zero extention in x64. But implementation actually uses generic approach and seems like a mini-combiner. Pass may combine two zero extends or combine zero extend with a constant as a special case but in other

Re: [PATCH] PR target/50038 fix: redundant zero extensions removal

2011-11-10 Thread Eric Botcazou
So, what about the patch? I think since we already have zee patch it would be great to use it as more general optimization. I tested it on EEMBC 2.0 on Atom and it showed 1% performance gain in geomean on 32 bit which is really good for such simple optimization. For OOO archs patch is not so

Re: [PATCH] PR target/50038 fix: redundant zero extensions removal

2011-11-10 Thread Ilya Enkovich
Hello Eric, Thanks for review! 2011/11/10 Eric Botcazou ebotca...@adacore.com: So, what about the patch? I think since we already have zee patch it would be great to use it as more general optimization. I tested it on EEMBC 2.0 on Atom and it showed 1% performance gain in geomean on 32 bit

Re: [PATCH] PR target/50038 fix: redundant zero extensions removal

2011-11-09 Thread Ilya Enkovich
Hello guys, So, what about the patch? I think since we already have zee patch it would be great to use it as more general optimization. I tested it on EEMBC 2.0 on Atom and it showed 1% performance gain in geomean on 32 bit which is really good for such simple optimization. For OOO archs patch is

Re: [PATCH] PR target/50038 fix: redundant zero extensions removal

2011-11-06 Thread Ilya Enkovich
Hello, 2011/11/5 Eric Botcazou ebotca...@adacore.com: Here is a patch which fixes redundant zero extensions problem. Issue is resolved by expanding implicit_zee pass functionality to cover zero and sign extends of different modes. Could please someone review it? Could you explain the

Re: [PATCH] PR target/50038 fix: redundant zero extensions removal

2011-11-06 Thread Richard Guenther
On Sun, Nov 6, 2011 at 11:50 AM, Ilya Enkovich enkovich@gmail.com wrote: Hello, 2011/11/5 Eric Botcazou ebotca...@adacore.com: Here is a patch which fixes redundant zero extensions problem. Issue is resolved by expanding implicit_zee pass functionality to cover zero and sign extends of

Re: [PATCH] PR target/50038 fix: redundant zero extensions removal

2011-11-06 Thread Ilya Enkovich
2011/11/6 Richard Guenther richard.guent...@gmail.com: On Sun, Nov 6, 2011 at 11:50 AM, Ilya Enkovich enkovich@gmail.com wrote: Hello, 2011/11/5 Eric Botcazou ebotca...@adacore.com: Here is a patch which fixes redundant zero extensions problem. Issue is resolved by expanding implicit_zee

Re: [PATCH] PR target/50038 fix: redundant zero extensions removal

2011-11-05 Thread Eric Botcazou
Here is a patch which fixes redundant zero extensions problem. Issue is resolved by expanding implicit_zee pass functionality to cover zero and sign extends of different modes. Could please someone review it? Could you explain the undelying idea? The current strategy of implicit-zee.c is

[PATCH] PR target/50038 fix: redundant zero extensions removal

2011-11-01 Thread Ilya Enkovich
Hi, Here is a patch which fixes redundant zero extensions problem. Issue is resolved by expanding implicit_zee pass functionality to cover zero and sign extends of different modes. Could please someone review it? Bootstrapped and checked on linux-x86_64. Thanks, Ilya --- 2011-11-01 Enkovich