Re: [PATCH] PR71752 - SLP: Maintain operand ordering when creating vec defs

2016-08-17 Thread Richard Biener
On Wed, Aug 17, 2016 at 12:52 PM, Alan Hayward wrote: > > > On 16/08/2016 10:01, "Alan Hayward" wrote: > >> >> >>On 16/08/2016 09:33, "Richard Biener" wrote: >> >>>On Mon, Aug 15, 2016 at 4:16 PM, Alan Hayward

Re: [PATCH] PR71752 - SLP: Maintain operand ordering when creating vec defs

2016-08-17 Thread Alan Hayward
On 16/08/2016 10:01, "Alan Hayward" wrote: > > >On 16/08/2016 09:33, "Richard Biener" wrote: > >>On Mon, Aug 15, 2016 at 4:16 PM, Alan Hayward >>wrote: >>> >>> >>> On 15/08/2016 12:17, "Richard Biener"

Re: [PATCH] PR71752 - SLP: Maintain operand ordering when creating vec defs

2016-08-16 Thread Richard Biener
On Mon, Aug 15, 2016 at 4:16 PM, Alan Hayward wrote: > > > On 15/08/2016 12:17, "Richard Biener" wrote: > >>On Mon, Aug 15, 2016 at 11:48 AM, Alan Hayward >>wrote: >>> The testcase pr71752.c was failing because the SLP code

Re: [PATCH] PR71752 - SLP: Maintain operand ordering when creating vec defs

2016-08-15 Thread Alan Hayward
On 15/08/2016 12:17, "Richard Biener" wrote: >On Mon, Aug 15, 2016 at 11:48 AM, Alan Hayward >wrote: >> The testcase pr71752.c was failing because the SLP code was generating >>an >> SLP >> vector using arguments from the SLP scalar stmts, but

Re: [PATCH] PR71752 - SLP: Maintain operand ordering when creating vec defs

2016-08-15 Thread Richard Biener
On Mon, Aug 15, 2016 at 11:48 AM, Alan Hayward wrote: > The testcase pr71752.c was failing because the SLP code was generating an > SLP > vector using arguments from the SLP scalar stmts, but was using the wrong > argument number. > > vect_get_slp_defs() is given a vector of

[PATCH] PR71752 - SLP: Maintain operand ordering when creating vec defs

2016-08-15 Thread Alan Hayward
The testcase pr71752.c was failing because the SLP code was generating an SLP vector using arguments from the SLP scalar stmts, but was using the wrong argument number. vect_get_slp_defs() is given a vector of operands. When calling down to vect_get_constant_vectors it uses i as op_num - making