Re: [PATCH] Practical Improvement to libgcc Complex Divide

2020-12-08 Thread Patrick McGehearty via Gcc-patches
It took some work, but I think I've responded to all the issues raised here. Patch V5 coming right after this mail. On 11/16/2020 8:34 PM, Joseph Myers wrote: On Tue, 8 Sep 2020, Patrick McGehearty via Gcc-patches wrote: This project started with an investigation related to https://gcc.gnu.org

Re: [PATCH] Practical Improvement to libgcc Complex Divide

2020-11-17 Thread Patrick McGehearty via Gcc-patches
Joseph, thank you for your detailed review and comments. I will get to work on the necessary revisions as well as find for a suitable place for sharing my random number generating tests. - patrick On 11/16/2020 8:34 PM, Joseph Myers wrote: On Tue, 8 Sep 2020, Patrick McGehearty via Gcc-patches

Re: [PATCH] Practical Improvement to libgcc Complex Divide

2020-11-16 Thread Joseph Myers
On Tue, 8 Sep 2020, Patrick McGehearty via Gcc-patches wrote: > This project started with an investigation related to > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59714. Study of Beebe[1] > provided an overview of past and recent practice for computing complex > divide. The current glibc implem

Re: [PATCH] Practical Improvement to libgcc Complex Divide

2020-11-10 Thread Patrick McGehearty via Gcc-patches
2nd ping - submitted Sept 8, 2020, last comment Sept 9, 2020 This patch is a correctness bug fix and not a change to any user visible interface. It makes a major improvement to complex divide accuracy, including algorithm improvements known for 8 years. It is highly desirable to get these changes

Re: [PATCH] Practical Improvement to libgcc Complex Divide

2020-10-13 Thread Patrick McGehearty via Gcc-patches
Ping - still need review of version 4 of this patch. It has been over a month since the last comment. - patrick On 9/9/2020 2:13 AM, Richard Biener wrote: On Tue, Sep 8, 2020 at 8:50 PM Patrick McGehearty via Gcc-patches wrote: (Version 4) (Added in version 4) Fixed Changelog entry to incl

Re: [PATCH] Practical Improvement to libgcc Complex Divide

2020-09-09 Thread Patrick McGehearty via Gcc-patches
On 9/9/2020 2:13 AM, Richard Biener wrote: Thanks for working on this. Speaking about performance and accuracy I spot a few opportunities to use FMAs [and eventually vectorization] - do FMAs change anything on the accuracy analysis (is there the chance they'd make it worse?). We might want t

Re: [PATCH] Practical Improvement to libgcc Complex Divide

2020-09-09 Thread Richard Biener via Gcc-patches
On Tue, Sep 8, 2020 at 8:50 PM Patrick McGehearty via Gcc-patches wrote: > > (Version 4) > > (Added in version 4) > Fixed Changelog entry to include __divsc3, __divdc3, __divxc3, __divtc3. > Revised description to avoid incorrect use of "ulp (units last place)". > Modified float precison case to u

[PATCH] Practical Improvement to libgcc Complex Divide

2020-09-08 Thread Patrick McGehearty via Gcc-patches
(Version 4) (Added in version 4) Fixed Changelog entry to include __divsc3, __divdc3, __divxc3, __divtc3. Revised description to avoid incorrect use of "ulp (units last place)". Modified float precison case to use double precision when double precision hardware is available. Otherwise float uses t