Re: Ping^2: [PATCH] RISC-V: Add -malign-data= option.

2019-07-22 Thread Jim Wilson
On Mon, Jul 22, 2019 at 2:50 PM Jim Wilson wrote: > On Mon, Jul 22, 2019 at 1:45 PM Ilia Diachkov > wrote: > > Ping: https://gcc.gnu.org/ml/gcc-patches/2019-06/msg01609.html It looks good. I modified the ChangeLog entry a little to change Added to New. I modified the doc entry to improve the

Re: Ping^2: [PATCH] RISC-V: Add -malign-data= option.

2019-07-22 Thread Jim Wilson
On Mon, Jul 22, 2019 at 1:45 PM Ilia Diachkov wrote: > Ping: https://gcc.gnu.org/ml/gcc-patches/2019-06/msg01609.html I'm looking at this now. I've been busy dealing with far too many problems, but have mostly caught up on my backlog, at least enough that I can deal with this now. I think the

Ping^2: [PATCH] RISC-V: Add -malign-data= option.

2019-07-22 Thread Ilia Diachkov
Ping: https://gcc.gnu.org/ml/gcc-patches/2019-06/msg01609.html Andrew, Palmer, I think all issues was fixed in https://gcc.gnu.org/ml/gcc-patches/2019-06/msg01689.html . Do you have any concerns about the patch? Best regards, Ilia.

Ping: [PATCH] RISC-V: Add -malign-data= option.

2019-07-15 Thread Ilia Diachkov
Hello, There are two weeks gone since the end of the patch discussion but no one has neither objected nor approved it. Please take a look to it and approve. Also please commit it since I have no write access. The updated version of the patch was attached to my message

Re: [PATCH] RISC-V: Add -malign-data= option.

2019-06-26 Thread Ilia Diachkov
Hmm, may I suggest use "natural" rather than "abi" and 32bit or 64bit rather than "word"; it is not obvious what abi means and it is not obvious what word means here; it could be either 32bit or 64bit depending on the option. It's actually worse: in RISC-V "word" always means 32-bit

Re: [PATCH] RISC-V: Add -malign-data= option.

2019-06-26 Thread Palmer Dabbelt
On Tue, 25 Jun 2019 15:58:53 PDT (-0700), pins...@gmail.com wrote: On Tue, Jun 25, 2019 at 3:46 PM Ilia Diachkov wrote: Hello, This patch adds new machine specific option -malign-data={word,abi} to RISC-V port. The option switches alignment of global variables and constants of

Re: [PATCH] RISC-V: Add -malign-data= option.

2019-06-25 Thread Andrew Pinski
On Tue, Jun 25, 2019 at 3:46 PM Ilia Diachkov wrote: > > Hello, > > This patch adds new machine specific option -malign-data={word,abi} to > RISC-V port. The option switches alignment of global variables and > constants of array/record/union types. The default value > (-malign-data=word) keeps

[PATCH] RISC-V: Add -malign-data= option.

2019-06-25 Thread Ilia Diachkov
] RISC-V: Add -malign-data= option. --- gcc/config/riscv/riscv-opts.h | 5 + gcc/config/riscv/riscv.c | 3 ++- gcc/config/riscv/riscv.h | 10 +++--- gcc/config/riscv/riscv.opt| 14 ++ gcc/doc/invoke.texi | 10 +- 5 files changed, 37 insertions