Re: [patches] Re: [PATCH] RISC-V: Implement __umulsidi3, umul_ppmm and __muluw3

2017-11-20 Thread Palmer Dabbelt
On Sun, 19 Nov 2017 23:31:56 PST (-0800), ja...@redhat.com wrote: On Sun, Nov 19, 2017 at 08:53:00PM -0800, Jim Wilson wrote: > 2017-11-24 Kito Cheng > > * longlong.h [__riscv] (__umulsidi3): Define. > [__riscv] (umul_ppmm) Likewise. > [__riscv] (__muluw3) Likewise.

Re: [patches] Re: [PATCH] RISC-V: Implement __umulsidi3, umul_ppmm and __muluw3

2017-11-19 Thread Jakub Jelinek
On Sun, Nov 19, 2017 at 08:53:00PM -0800, Jim Wilson wrote: > > 2017-11-24 Kito Cheng > > > > * longlong.h [__riscv] (__umulsidi3): Define. > > [__riscv] (umul_ppmm) Likewise. > > [__riscv] (__muluw3) Likewise. BTW, two colons missing after ) Jakub

Re: [patches] Re: [PATCH] RISC-V: Implement __umulsidi3, umul_ppmm and __muluw3

2017-11-19 Thread Jim Wilson
On Sun, Nov 19, 2017 at 7:34 PM, Kito Cheng wrote: > > I prefer write more comment in the code instead of ChangeLog, I add > more comment in __muluw3. > btw, long times ago, Vladimir was told me[1] it should contain what is > done but not why it is done? Yes, the ChangeLog entry only states what

Re: [patches] Re: [PATCH] RISC-V: Implement __umulsidi3, umul_ppmm and __muluw3

2017-11-19 Thread Kito Cheng
>> 2017-11-17 Kito Cheng >> >> * longlong.h [__riscv] (__umulsidi3): Define. >> [__riscv] (umul_ppmm) Likewise. >> [__riscv] (__muluw3) Likewise. > > > Apparently the point of this is that by defining __mulsi3/__muldi3 as an > extended asm, we get better register allo

Re: [PATCH] RISC-V: Implement __umulsidi3, umul_ppmm and __muluw3

2017-11-17 Thread Jim Wilson
On 11/17/2017 04:09 PM, Palmer Dabbelt wrote: From: Kito Cheng 2017-11-17 Kito Cheng * longlong.h [__riscv] (__umulsidi3): Define. [__riscv] (umul_ppmm) Likewise. [__riscv] (__muluw3) Likewise. Apparently the point of this is that by defining __mulsi3/__muldi3 a

[PATCH] RISC-V: Implement __umulsidi3, umul_ppmm and __muluw3

2017-11-17 Thread Palmer Dabbelt
From: Kito Cheng 2017-11-17 Kito Cheng * longlong.h [__riscv] (__umulsidi3): Define. [__riscv] (umul_ppmm) Likewise. [__riscv] (__muluw3) Likewise. --- include/longlong.h | 50 ++ 1 file changed, 50 insertions(+) diff -