Re: [PATCH] RISC-V: Refactor and cleanup fma patterns

2023-09-19 Thread Lehua Ding
Hi Patrick and Robin, I fixed this ICE by this patch (https://gcc.gnu.org/pipermail/gcc-patches/2023-September/630969.html). I didn't repeat this problem at first because I was using -O0 compiled GCC. It reappeared after it was changed to -O2. Sorry for introducing this problem, and thanks

Re: [PATCH] RISC-V: Refactor and cleanup fma patterns

2023-09-19 Thread Lehua Ding
Hi Patrick and Robin, Thanks for reporting, I'll fix this as soon as I can. On 2023/9/20 05:53, Robin Dapp wrote: Hi Patrick, thanks for reporting. Before seeing your message here I already opened a PR https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111488 Regards Robin -- Best, Lehua

Re: [PATCH] RISC-V: Refactor and cleanup fma patterns

2023-09-19 Thread Robin Dapp
Hi Patrick, thanks for reporting. Before seeing your message here I already opened a PR https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111488 Regards Robin

Re: [PATCH] RISC-V: Refactor and cleanup fma patterns

2023-09-18 Thread Lehua Ding
il.com>; palmer <mailto:pal...@rivosinc.com>; jeffreyalaw <mailto:jeffreya...@gmail.com>; lehua.ding <mailto:lehua.d...@rivai.ai> *Subject:* [PATCH] RISC-V: Refactor and cleanup fma patterns At present, FMA autovec's patterns do not fully use the correspondi

Re: [PATCH] RISC-V: Refactor and cleanup fma patterns

2023-09-18 Thread juzhe.zh...@rivai.ai
: Refactor and cleanup fma patterns At present, FMA autovec's patterns do not fully use the corresponding pattern in vector.md. The previous reason is that the merge operand of pattern in vector.md cannot be VUNDEF. Now allowing it to be VUNDEF, reunify insn used for reload pass into vector.md

[PATCH] RISC-V: Refactor and cleanup fma patterns

2023-09-18 Thread Lehua Ding
At present, FMA autovec's patterns do not fully use the corresponding pattern in vector.md. The previous reason is that the merge operand of pattern in vector.md cannot be VUNDEF. Now allowing it to be VUNDEF, reunify insn used for reload pass into vector.md, and the corresponding vlmax pattern in